Closed
Bug 1102013
Opened 10 years ago
Closed 10 years ago
mail/installer/package-manifest.in needs to be updated after the cleanup in bug 1096494
Categories
(Thunderbird :: Installer, defect)
Thunderbird
Installer
Tracking
(thunderbird36 fixed)
RESOLVED
FIXED
Thunderbird 36.0
Tracking | Status | |
---|---|---|
thunderbird36 | --- | fixed |
People
(Reporter: spohl, Assigned: spohl)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1096494 +++
Unfortunately, I didn't realize that the patch in bug 1096494 would bust comm-central on OSX. All that seems to be necessary is for mail/installer/package-manifest.in to use @RESPATH@ instead of @BINPATH@ for the resources that are located under Contents/Resources. The patch in bug 1096494 should be a good illustration how this was done for Firefox.
Josiah, since you've handled most of the v2 signing changes for TB, is this something that you could tackle? Happy to assist with feedback or anything else that would be helpful.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 3•10 years ago
|
||
Yes, that's fine. Thanks for filing the bug!
Assignee: nobody → josiah
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•10 years ago
|
||
Thanks, Josiah! I actually found some time this morning to write the patch myself. I hope you didn't get started yet. Thanks for offering your help though!
Assignee: josiah → spohl.mozilla.bugs
Attachment #8526098 -
Flags: review?(Pidgeot18)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 7•10 years ago
|
||
Comment on attachment 8526098 [details] [diff] [review]
Patch
Review of attachment 8526098 [details] [diff] [review]:
-----------------------------------------------------------------
Ugh, I wish packaging were more sane. I pushed this to try and it passed tests at least as well as anything else these days, and I don't see anything that stands out as weird or wrong, so r+.
Attachment #8526098 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 8•10 years ago
|
||
Not sure how approvals etc. work on comm-central, and it's getting too late here to watch the tree. Setting checkin-needed in the hope that this keyword applies to comm-central too.
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Updated•10 years ago
|
status-thunderbird36:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•