Closed
Bug 1102836
Opened 10 years ago
Closed 10 years ago
Close button hit area tweaks in tabs panel
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(2 files)
(deleted),
patch
|
mhaigh
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mhaigh
:
review+
|
Details | Diff | Splinter Review |
1. Only grow hit area in new tablet UI 2. Make hit area slightly taller
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8526688 [details] [diff] [review] Only grow close button hit area in new tablet UI (r=mhaigh) This code should only run on the new tablet UI as TabsLayoutItemView is shared across all our UIs.
Attachment #8526688 -
Flags: review?(mhaigh)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8526689 [details] [diff] [review] Make close button hit area a bit taller (r=mhaigh) Ensure the hit area is 40x40.
Attachment #8526689 -
Flags: review?(mhaigh)
Comment 5•10 years ago
|
||
Comment on attachment 8526689 [details] [diff] [review] Make close button hit area a bit taller (r=mhaigh) Looks good
Attachment #8526689 -
Flags: review?(mhaigh) → review+
Comment 6•10 years ago
|
||
Comment on attachment 8526688 [details] [diff] [review] Only grow close button hit area in new tablet UI (r=mhaigh) Review of attachment 8526688 [details] [diff] [review]: ----------------------------------------------------------------- Yup
Attachment #8526688 -
Flags: review?(mhaigh) → review+
Comment 7•10 years ago
|
||
Comment on attachment 8526689 [details] [diff] [review] Make close button hit area a bit taller (r=mhaigh) Review of attachment 8526689 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/tabs/TabsLayoutItemView.java @@ +108,3 @@ > // we make it as tall as the parent view and 40dp across. > final int targetHitArea = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP, 40, getResources().getDisplayMetrics());; > final View parent = ((View) mCloseButton.getParent()); You can get rid of the parent variable now
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b088ca59509d https://hg.mozilla.org/integration/fx-team/rev/18426b83a5f7
https://hg.mozilla.org/mozilla-central/rev/b088ca59509d https://hg.mozilla.org/mozilla-central/rev/18426b83a5f7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•