Closed
Bug 1102852
Opened 10 years ago
Closed 10 years ago
[EME] gmp-decryption.h should allow the CDM to indicate the type of the message emitted
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: hsivonen, Assigned: jwwang)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
The SessionMessage() method in http://dxr.mozilla.org/mozilla-central/source/dom/media/gmp/gmp-api/gmp-decryption.h#128 does not allow the CDM to specifify the type of the message per
https://w3c.github.io/encrypted-media/#idl-def-MediaKeyMessageType
and
https://www.w3.org/Bugs/Public/show_bug.cgi?id=27124
.
Expected the method to take an enum with four possible values:
License request
License renewal
License release
Individualization request
Updated•10 years ago
|
Summary: gmp-decryption.h should allow the CDM to indicate the type of the message emitted → [EME] gmp-decryption.h should allow the CDM to indicate the type of the message emitted
Comment 1•10 years ago
|
||
jw: would you be able to take this bug? It involves changing the GMP API and the EME JS APIs to include the MediaKeyMessageType enum on MediaKeyMessageEvent, and removing the destinationURL from MediaKeyMessageEvent.
Comment 2•10 years ago
|
||
jw: would you be able to take this bug? It involves changing the GMP API and the EME JS APIs to include the MediaKeyMessageType enum on MediaKeyMessageEvent, and removing the destinationURL from MediaKeyMessageEvent.
Flags: needinfo?(jwwang)
Assignee | ||
Comment 4•10 years ago
|
||
add MediaKeyMessageType to and remove destinationURL from MediaKeyMessageEvent.
Attachment #8547544 -
Flags: review?(cpearce)
Comment 5•10 years ago
|
||
Comment on attachment 8547544 [details] [diff] [review]
1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v1.patch
Review of attachment 8547544 [details] [diff] [review]:
-----------------------------------------------------------------
Awesome.
We should probably change the mochitests to verify that the MediaKeyMessage events we receive have an expected type too.
Attachment #8547544 -
Flags: review?(cpearce) → review+
Comment 6•10 years ago
|
||
Comment on attachment 8547544 [details] [diff] [review]
1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v1.patch
Review of attachment 8547544 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/media/gmp/gmp-api/gmp-decryption.h
@@ +218,5 @@
> kGMPPersistentSession = 1,
> kGMPSessionInvalid = 2 // Must always be last.
> };
>
> +#define GMP_API_DECRYPTOR "eme-decrypt-v3"
You'll also need to change the .info files so that they report that they support the new API name:
/dom/media/gmp-plugin/fake.info
/media/gmp-clearkey/0.1/clearkey.info
Assignee | ||
Comment 7•10 years ago
|
||
address nits in comment 6.
Attachment #8547544 -
Attachment is obsolete: true
Attachment #8547908 -
Flags: review+
Assignee | ||
Comment 9•10 years ago
|
||
Flags: needinfo?(jwwang)
Keywords: checkin-needed
Assignee | ||
Comment 11•10 years ago
|
||
rebase.
Attachment #8547908 -
Attachment is obsolete: true
Attachment #8548601 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 12•10 years ago
|
||
needs dom peer review for bundling: dom/webidl/MediaKeyMessageEvent.webidl changes
Flags: needinfo?(jwwang)
Keywords: checkin-needed
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8548601 [details] [diff] [review]
1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v3.patch
Hi bz,
Can you review dom/webidl/MediaKeyMessageEvent.webidl? Thanks.
Flags: needinfo?(jwwang)
Attachment #8548601 -
Flags: review+ → review?(bzbarsky)
Assignee | ||
Comment 14•10 years ago
|
||
Comment 15•10 years ago
|
||
Comment on attachment 8548601 [details] [diff] [review]
1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v3.patch
r=me
Attachment #8548601 -
Flags: review?(bzbarsky) → review+
Comment 16•10 years ago
|
||
Comment 17•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•10 years ago
|
Blocks: eme-platform-uplift
Comment 18•10 years ago
|
||
Patch for beta branch as part of EME platform uplift.
Updated•10 years ago
|
Assignee: jwwang → cpearce
Updated•10 years ago
|
Assignee: cpearce → jwwang
Comment 19•10 years ago
|
||
status-firefox37:
--- → fixed
Comment 20•10 years ago
|
||
Comment on attachment 8572285 [details] [diff] [review]
Beta patch
Requesting retroactive approval for Beta landing as part of EME platform uplift.
Attachment #8572285 -
Flags: approval-mozilla-beta?
Updated•10 years ago
|
status-firefox38:
--- → fixed
Comment 21•10 years ago
|
||
Comment on attachment 8572285 [details] [diff] [review]
Beta patch
Previously approved as part of the EME platform landing on Beta.
Attachment #8572285 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•