Closed
Bug 1103189
Opened 10 years ago
Closed 9 years ago
WebSockets should allow developer tools code to observe socket activity
Categories
(Core :: Networking: WebSockets, defect)
Core
Networking: WebSockets
Tracking
()
RESOLVED
DUPLICATE
of bug 1203802
People
(Reporter: jimb, Unassigned, Mentored, NeedInfo)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
To help implement developer tools that monitor WebSockets activity, the WebSocket API implementation (dom/base/WebSocket.cpp) should notify observers or some dedicated inspector type of connection status changes and messages.
Comment 1•10 years ago
|
||
It includes one function and 3 calls to this function. The function is named notifyWebsocketObservers(). search for 'jiabin' for the places in which calls this function : )
Reporter | ||
Comment 2•10 years ago
|
||
This is very much like bug 977858, although that suggests a very different approach.
Comment 3•10 years ago
|
||
Attachment #8527066 -
Attachment is obsolete: true
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8527095 [details] [diff] [review]
websocketcpp_diff.patch
Review of attachment 8527095 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/base/src/WebSocket.cpp
@@ +618,5 @@
> //-----------------------------------------------------------------------------
> // WebSocketImpl::nsIWebSocketListener methods:
> //-----------------------------------------------------------------------------
>
> +// jiabin added
Not a substantial point, but: by the time we land, these comments will all need to be removed. The patches and the hg history keep track of who changed what, in a non-obtrusive way. It generally works pretty well to let hg remind you of what you've changed.
Reporter | ||
Comment 5•10 years ago
|
||
Note to other readers: This is a student project that I'm mentoring. Please treat patches as works in progress by folks new to open source and Firefox.
Comment 6•10 years ago
|
||
Can I take it..me too new to OS..had solved 1 bug earlier
Comment 7•10 years ago
|
||
(In reply to Gaurav Pruthi from comment #6)
> Can I take it..me too new to OS..had solved 1 bug earlier
I will be submitting a patch very soon.
Hold on a little bit longer
Comment 8•9 years ago
|
||
(In reply to jiabinc.sea from comment #7)
> (In reply to Gaurav Pruthi from comment #6)
> > Can I take it..me too new to OS..had solved 1 bug earlier
>
> I will be submitting a patch very soon.
> Hold on a little bit longer
Any progress on this?
Flags: needinfo?(jiabinc.sea)
Comment 9•9 years ago
|
||
Folding this under Andrea's bug. he can determine if this still relevant.
Updated•9 years ago
|
No longer blocks: network-websocket-inspector
Comment 10•9 years ago
|
||
I think this bug is covered by bug 1203802. In my patches you can see the frames received and sent by the WebSocket.
I mark this bug as duplicate but reopen it in case I'm wrong.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•