Closed
Bug 1103439
Opened 10 years ago
Closed 10 years ago
ImageLib's chrome tests need to clear the chrome image cache, not the regular image cache
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: seth, Assigned: seth)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
ImageLib has a number of chrome tests that need to clear the cache to work properly. Unfortunately, the function they're using to do it, |clearImageCache|, does not clear the correct cache - the images used by chrome tests are chrome images, but |clearImageCache| clears only the regular image cache.
We need to add another function that clears both caches, and call it in all ImageLib mochitest-chrome tests.
I believe this may be the real cause of bug 1100497, so I'm going to try reenabling it after this lands.
|
Assignee | |
Comment 1•10 years ago
|
||
(In reply to Seth Fowler [:seth] from comment #0)
> I believe this may be the real cause of bug 1100497, so I'm going to try
> reenabling it after this lands.
Reenabling 'test_animation.html', to be clear.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Try job here:
https://tbpl.mozilla.org/?tree=Try&rev=9904a4cbbe31
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8527247 -
Attachment is obsolete: true
Attachment #8527247 -
Flags: review?(tnikkel)
|
||
Updated•10 years ago
|
Attachment #8527249 -
Flags: review?(tnikkel) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Thanks for the review! Pushed:
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/faa77ca026ea
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•