Closed
Bug 1103574
Opened 10 years ago
Closed 10 years ago
Use Web Audio API to play keyboard clicker sounds
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S1 (5dec)
People
(Reporter: timdream, Assigned: timdream)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
Currently we play these sounds with <audio> tags and some platforms does not handle multiple tags quite well (*cough* iOS *cough*). By switching to Web Audio API it would help us remove some issues.
I have a patch ready.
|
Assignee | |
Comment 1•10 years ago
|
||
However, my patch does release audioContext when the keyboard is hidden since FeedbackPlayer and it's children does not get any events when the keyboard is hidden (except the global visibilitychange).
I am not sure if this a strong requirement or not -- yet.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8527496 [details]
mozilla-b2g:master PR#26397
The tests takes more time to set up than the code because the code kinds of talk to two APIs at once, but I think this is good enough for review.
Attachment #8527496 -
Flags: review?(jlu)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8527496 [details]
mozilla-b2g:master PR#26397
Good job on creating those mocks and interfacing them with the tests (Y)
Attachment #8527496 -
Flags: review?(jlu) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=0144634afcc8
master: https://github.com/mozilla-b2g/gaia/commit/1917c4dfb81953a1f9c688780ba702fea4229d1b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.2 S1 (5dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•