Note: I'm abusing this bug for yield-rootGuid removal in the test.

Comment on attachment 8527331 [details] [diff] [review] patch Review of attachment 8527331 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/places/PlacesTransactions.jsm @@ +67,5 @@ > * a live bookmark is associated. > * - tag - a string. > * - tags: an array of strings. > * - guid, parentGuid, newParentGuid: a valid places GUID string. > + * - guids: an array of valid places GUID strings. really-nit: ucfirst Places ::: toolkit/components/places/tests/unit/test_async_transactions.js @@ +251,1 @@ > } nit: fwiw, now this is not very useful and could be hardcoded... @@ +1010,5 @@ > }); > > add_task(function* test_edit_keyword() { > + let bm_info = { parentGuid: rootGuid > + , url: NetUtil.newURI("http://test.edit.keyword") }; don't we also accept URL or href now? @@ +1541,5 @@ > +add_task(function* test_annotate_multiple_items() { > + let parentGuid = rootGuid; > + let guids = [ > + yield PT.NewBookmark({ url: "about:blank", parentGuid }).transact(), > + yield PT.NewFolder({ title: "Test Folder", parentGuid }).transact()]; nit: "];" on new line please

Marco, please add this bug to the current (last) iteration.