Closed Bug 1103867 Opened 10 years ago Closed 9 years ago

Incorect handling of execution contexts in AVM1 in closure.

Categories

(Firefox Graveyard :: Shumway, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: mbx, Assigned: yury)

References

Details

Or, at least I think this is the problem. See, Icycle2_255.swf When running one of the event handlers, we have a situation where both `currentContext.defaultTarget === null` and `currentContext.currentTarget === null`. As far as I can tell, this should never happen. The error appears in avm1GetVariable when variableName is "mbutton". currentTarget ends up being null, which then triggers an exception. I was able to reproduce the bug consistently in Chrome with the following set of patches applied: https://github.com/mozilla/shumway/pull/1884
Assignee: nobody → ydelendik
Blocks: shumway-m3
Should be investigated as it has the potential to affect lots of content. If it isn't fixed by now.
Blocks: shumway-m4
No longer blocks: shumway-m3
This works. As the game does to a substantial extent: the intro looks exactly right to me, and the first level is fully playable. Well, except for being *really* slow - which the intro wasn't. So all in all, a pretty nice improvement.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.