Closed
Bug 1103872
Opened 10 years ago
Closed 10 years ago
[Bluetooth] Port Bug 1091588 to bluetooth2
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(4 files, 2 obsolete files)
|
(deleted),
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8528379 -
Flags: review?(btian)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8528380 -
Flags: review?(btian)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8528381 -
Flags: review?(btian)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8528382 -
Flags: review?(btian)
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8528379 [details] [diff] [review]
[01] Bug 1103872: Add helpers for Bluetooth daemon Handsfree support
Review of attachment 8528379 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8528379 -
Flags: review?(btian) → review+
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8528380 [details] [diff] [review]
[02] Bug 1103872: Add Handsfree module for Bluetooth daemon
Review of attachment 8528380 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8528380 -
Flags: review?(btian) → review+
|
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8528381 [details] [diff] [review]
[03] Bug 1103872: Add Handsfree interface for Bluetooth daemon
Review of attachment 8528381 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with typo addressed.
::: dom/bluetooth2/bluedroid/BluetoothDaemonHandsfreeInterface.h
@@ +331,5 @@
> +
> + enum {
> + MODE_HEADSET = 0x00,
> + MODE_NARROWBAND_SPEECH = 0x01,
> + MODE_NARRAWBAND_WIDEBAND_SPEECH = 0x02
typo: NARR'O'WBAND_WIDEBAND
Attachment #8528381 -
Flags: review?(btian) → review+
|
|
||
Comment 8•10 years ago
|
||
Comment on attachment 8528382 [details] [diff] [review]
[04] Bug 1103872: Support Handsfree profile when using Bluetooth daemon
Review of attachment 8528382 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8528382 -
Flags: review?(btian) → review+
|
|
Assignee | |
Comment 9•10 years ago
|
||
Changes since v1:
- fixed typo in enum constant
Attachment #8528382 -
Attachment is obsolete: true
Attachment #8530228 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8530228 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 10•10 years ago
|
||
Comment on attachment 8528382 [details] [diff] [review]
[04] Bug 1103872: Support Handsfree profile when using Bluetooth daemon
Restoring correct patch [04](v1)
Attachment #8528382 -
Attachment is obsolete: false
|
|
Assignee | |
Comment 11•10 years ago
|
||
Changes since v1:
- fixed typo in enum constant
Attachment #8528381 -
Attachment is obsolete: true
Attachment #8530230 -
Flags: review+
|
|
Assignee | |
Comment 12•10 years ago
|
||
Thanks!
https://hg.mozilla.org/integration/b2g-inbound/rev/cb9fb4a16519
https://hg.mozilla.org/integration/b2g-inbound/rev/b9b07db1e846
https://hg.mozilla.org/integration/b2g-inbound/rev/6708343dd7ee
https://hg.mozilla.org/integration/b2g-inbound/rev/eb2a8052241b
https://treeherder.mozilla.org/ui/#/jobs?repo=b2g-inbound&revision=eb2a8052241b
|
||
Comment 13•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cb9fb4a16519
https://hg.mozilla.org/mozilla-central/rev/b9b07db1e846
https://hg.mozilla.org/mozilla-central/rev/6708343dd7ee
https://hg.mozilla.org/mozilla-central/rev/eb2a8052241b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•