Closed
Bug 1104660
Opened 10 years ago
Closed 10 years ago
NativeFileWatcherWin.cpp uses an uninitialized object when failing to watch in |AddPathRunnableMethod|
Categories
(Toolkit Graveyard :: OS.File, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: Dexter, Assigned: Dexter)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
|watchedResource->mPath| should not be used at http://dxr.mozilla.org/mozilla-central/source/toolkit/components/filewatcher/NativeFileWatcherWin.cpp#696, since |watchedResource| it is only valid when a valid watch has been already created.
|wrappedParameters->mPath| should be used instead.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → alessio.placitelli
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8528321 -
Flags: review?(dteller)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8528321 [details] [diff] [review]
bug1104660.patch
Review of attachment 8528321 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch.
Attachment #8528321 -
Flags: review?(dteller) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Here's a link to the try push (win32, xpcshell only): https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ceaa43e7ae28
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla36
|
||
Updated•2 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•