Closed
Bug 1104846
Opened 10 years ago
Closed 10 years ago
The search engine favicons are distorted in search preferences on Windows
Categories
(Firefox :: Search, defect)
Tracking
()
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Felipe
:
review+
lmandel
:
approval-mozilla-beta+
lmandel
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
I fixed the Linux case in bug 1102911, but bug 1102911 comment 6 points out that it still exists on Windows.
+++ This bug was initially created as a clone of Bug #1102911 +++
Reproducible with Firefox 34 Beta 11 - BuildID: 20141120192249
Environment: Windows 7 x64, Windows 8 x86, Ubuntu 12.04 x86, Mac OS X 10.9.5
Steps to reproduce:
1. Open Firefox and go to Preferences -> Search.
2. See how the search engine favicons display in the list from the bottom.
Expected results:
Favicons display same as in the drop-down selector (16x16).
Actual results:
Favicons display distorted (16x14).
|
Assignee | |
Updated•10 years ago
|
Summary: The search engine favicons are distorted in search preferences on Linux → The search engine favicons are distorted in search preferences on Windows
|
|
Assignee | |
Comment 1•10 years ago
|
||
The Windows CSS has a 1px transparent border.
Assignee: nobody → florian
Attachment #8528454 -
Flags: review?(felipc)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8528454 [details] [diff] [review]
Fix
Why are you putting this in a content stylesheet rather than themes?
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #2)
> Comment on attachment 8528454 [details] [diff] [review]
> Fix
>
> Why are you putting this in a content stylesheet rather than themes?
Because this was initially developed as an add-on, and having only one CSS file rather than one for content + one per platform was significantly easier to maintain.
It's one of the things I intend to cleanup when/before landing this new code on central. For the beta patch, I prefer keeping the changes to the strict minimum.
|
||
Updated•10 years ago
|
status-firefox33:
--- → unaffected
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
tracking-firefox34:
--- → +
tracking-firefox35:
--- → +
tracking-firefox36:
--- → +
Flags: firefox-backlog?
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8528454 [details] [diff] [review]
Fix
r+ with the expectation that we will clean up this shortly after the time pressure for beta winds down
Attachment #8528454 -
Flags: review?(felipc) → review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8528454 -
Flags: approval-mozilla-release?
Attachment #8528454 -
Flags: approval-mozilla-beta?
Flags: qe-verify+
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8528454 [details] [diff] [review]
Fix
Reviewed with Florian. Release+ Beta+
Attachment #8528454 -
Flags: approval-mozilla-release?
Attachment #8528454 -
Flags: approval-mozilla-release+
Attachment #8528454 -
Flags: approval-mozilla-beta?
Attachment #8528454 -
Flags: approval-mozilla-beta+
|
||
Comment 6•10 years ago
|
||
|
||
Comment 8•10 years ago
|
||
Verified as fixed using Firefox 34.0 build 2 (20141125180439) under Win 7 and Win 8.1 64-bit.
|
|
Assignee | |
Comment 9•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 10•10 years ago
|
||
Hi Florian, can you provide a point value.
Status: NEW → ASSIGNED
Iteration: --- → 37.1
Flags: needinfo?(florian)
Flags: firefox-backlog?
Flags: firefox-backlog+
|
|
Assignee | |
Updated•10 years ago
|
Points: --- → 1
Flags: needinfo?(florian)
|
||
Comment 11•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
|
|
Assignee | |
Comment 12•10 years ago
|
||
|
|
||
Comment 13•10 years ago
|
||
Verified as fixed using Firefox 35 beta 1 (20141201162954) and Firefox Developer Edition 36.0a2 20141202004003
You need to log in
before you can comment on or make changes to this bug.
Description
•