Closed
Bug 1104855
Opened 10 years ago
Closed 10 years ago
Don't rebuild the omnijar on every Gradle build
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
All
Android
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(1 file, 1 obsolete file)
Pretty clear win here: we're currently forcing a stage-package of the omnijar on every Gradle build. The solution is to make the Omnijar Gradle task know its inputs and outputs, so that Gradle knows when the task's target is out of date.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8528479 -
Flags: review?(margaret.leibovic)
|
|
Assignee | |
Comment 2•10 years ago
|
||
/r/995 - Bug 1104855 - Don't rebuild the omnijar on every Gradle build. r=margaret
Pull down this commit:
hg pull review -r 04b3628ecbbbd9b2d2e2990139b2a76a35f31bdb
|
||
Updated•10 years ago
|
Attachment #8528479 -
Flags: review?(margaret.leibovic) → review+
|
|
||
Comment 3•10 years ago
|
||
https://reviewboard.mozilla.org/r/993/#review549
Rubber stamp!
::: mobile/android/base/Makefile.in
(Diff revision 1)
> -gradle-targets: $(abspath $(DIST)/fennec/$(OMNIJAR_NAME))
Testing out RB comments. Looks good!
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
|
|
Assignee | |
Comment 6•9 years ago
|
||
Attachment #8528479 -
Attachment is obsolete: true
Attachment #8618721 -
Flags: review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Component: Build Config → Build Config & IDE Support
Product: Core → Firefox for Android
Target Milestone: mozilla36 → ---
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•