Closed
Bug 1104921
Opened 10 years ago
Closed 10 years ago
UITour: Add Loop panel targets
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: MattN, Assigned: MattN)
References
Details
Attachments
(1 file, 2 obsolete files)
* New Room button
* List of active rooms
* Sign Up / Sign In
We won't auto-open the panel since that is quite a bit of work so this depends on bug 1080943. The conversation window target of the copy/email buttons will be handled in their own bug.
Try push: https://tbpl.mozilla.org/?tree=Try&rev=99269e45cb74
Flags: qe-verify-
Flags: firefox-backlog+
Updated•10 years ago
|
Iteration: 36.3 → 37.1
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
/r/1089 - Bug 1104921 - UITour: Add Loop panel targets. r=Unfocused
Pull down this commit:
hg pull review -r aaf990a20a02f4863c8ebc7be48cfcfac5855b18
Assignee | ||
Updated•10 years ago
|
Attachment #8528515 -
Attachment is obsolete: true
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8531030 [details]
MozReview Request: bz://1104921/MattN
Try push: https://tbpl.mozilla.org/?tree=Try&rev=61b1ab06e702
Attachment #8531030 -
Flags: feedback?(bmcbride)
Updated•10 years ago
|
Attachment #8531030 -
Flags: review+
Comment 4•10 years ago
|
||
https://reviewboard.mozilla.org/r/1087/#review649
::: browser/modules/UITour.jsm
(Diff revision 1)
> - if (!this.isElementVisible(aAnchor.node))
> + if (!this.isElementVisible(aAnchor.node)) // TODO
Still to-do?
::: browser/modules/UITour.jsm
(Diff revision 1)
> + return aTarget.targetName.startsWith("loop-"); // TODO: separate convo window
Should reference a bug number here.
Updated•10 years ago
|
Attachment #8531030 -
Flags: feedback?(bmcbride)
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Matthew N. [:MattN] from comment #3)
> Try push: https://tbpl.mozilla.org/?tree=Try&rev=61b1ab06e702
Downloads builds here: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mozilla@noorenberghe.ca-61b1ab06e702/
Assignee | ||
Updated•10 years ago
|
Attachment #8531030 -
Flags: review+ → review?(bmcbride)
Assignee | ||
Comment 6•10 years ago
|
||
/r/1089 - Bug 1104921 - UITour: Add Loop panel targets. r=Unfocused
Pull down this commit:
hg pull review -r 53ff9adacb6e7085440d16e2d152a6f026e080dd
Updated•10 years ago
|
Attachment #8531030 -
Flags: review?(bmcbride) → review+
Comment 7•10 years ago
|
||
https://reviewboard.mozilla.org/r/1087/#review661
::: browser/modules/UITour.jsm
(Diff revisions 1 - 2)
> + return loopBrowser;
This is misleading - should explicitly return null.
Assignee | ||
Comment 8•10 years ago
|
||
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 9•10 years ago
|
||
Backed out for bc2 failures on some platforms:
https://hg.mozilla.org/integration/fx-team/rev/f3278982666a
120 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour_loop.js | Timeout waiting for popup at anchor: Info panel should be anchored to the new room button -
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 10•10 years ago
|
||
Assignee | ||
Comment 11•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 12•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment 13•10 years ago
|
||
Comment on attachment 8531030 [details]
MozReview Request: bz://1104921/MattN
[Triage Comment]
Needed for Fx35 Hello tour, no unusual risk. (And basically all the changes here are constrained to UITour.jsm)
Attachment #8531030 -
Flags: approval-mozilla-beta+
Attachment #8531030 -
Flags: approval-mozilla-aurora+
Comment 14•10 years ago
|
||
Updated•10 years ago
|
Assignee | ||
Comment 15•10 years ago
|
||
Assignee | ||
Comment 16•9 years ago
|
||
Attachment #8531030 -
Attachment is obsolete: true
Attachment #8618722 -
Flags: review+
Assignee | ||
Comment 17•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•