Closed Bug 1104955 Opened 10 years ago Closed 9 years ago

Implement IDL [Unscopable]

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: annevk, Assigned: bzbarsky)

References

(
URL
)

Details

(Keywords: dev-doc-needed)

Attachments

(3 files, 3 obsolete files)

part 1. Add parsing for [Unscopeable] in IDL
(deleted), patch
khuey
: review+
Details | Diff | Splinter Review
part 2. Make codegen output a list of unscopable names that we can then pass to CreateInterfaceObjects
(deleted), patch
khuey
: review+
Details | Diff | Splinter Review
part 3. Pass our unscopable names to CreateInterfaceObjects and have it define the right thing on the prototype
(deleted), patch
khuey
: review+
Details | Diff | Splinter Review
If we implement @@unscopables and [Unscopable] we can implement some new features in DOM and improve existing features.
Bug 1054759 needs to happen first, obviously.
Depends on: 1054759
Blocks: 911477
Blocks: dom-requests
No longer blocks: dom-requests
Attached patch part 1. Add parsing for [Unscopeable] in IDL (obsolete) (deleted) — — Splinter Review
Attachment #8734853 - Flags: review?(khuey)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Note that this does not take into account the exposed/enabled state of the relevant properties. This should be OK, I hope. Taking that state into account would be rather annoying, unfortunately. We could make codegen fail if something is conditionally exposed and unscopable, if desired... Also note that I'm using the ES6 spelling of "unscopable", which seems more correct to me in terms the way "able" is usually added to words than the IDL "unscopeable".
Attachment #8734855 - Flags: review?(khuey)
Spec is changing in terms spelling (note comment 3 for comparison), so going to update the relevant bits of these patches.
Summary: Implement IDL [Unscopeable] → Implement IDL [Unscopable]
Attachment #8735146 - Flags: review?(khuey)
Attachment #8734853 - Attachment is obsolete: true
Attachment #8734853 - Flags: review?(khuey)
Note that this does not take into account the exposed/enabled state of the relevant properties. This should be OK, I hope. Taking that state into account would be rather annoying, unfortunately. We could make codegen fail if something is conditionally exposed and unscopable, if desired...
Attachment #8735147 - Flags: review?(khuey)
Attachment #8734855 - Attachment is obsolete: true
Attachment #8734855 - Flags: review?(khuey)
Attachment #8734856 - Attachment is obsolete: true
Attachment #8734856 - Flags: review?(khuey)
Comment on attachment 8735146 [details] [diff] [review] part 1. Add parsing for [Unscopeable] in IDL Review of attachment 8735146 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/parser/WebIDL.py @@ +4110,5 @@ > [attr.location, self.location]) > + elif identifier == "Unscopable": > + if not attr.noArguments(): > + raise WebIDLError("[Unscopable] must take no arguments", > + [attr.location]) nit: whitespace at EOL @@ +4818,5 @@ > [attr.location, self.location]) > + elif identifier == "Unscopable": > + if not attr.noArguments(): > + raise WebIDLError("[Unscopable] must take no arguments", > + [attr.location]) and here
Attachment #8735146 - Flags: review?(khuey) → review+
Added ddn so that we update our guide on what info is available in the webidl of an interface, and how to translate it in the docs.
Keywords: dev-doc-needed
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: