Closed
Bug 1105
Opened 26 years ago
Closed 25 years ago
new_comment.cgi allows blank lines and extraineous spaces
Categories
(Bugzilla :: Bugzilla-General, defect, P2)
Tracking
()
VERIFIED
FIXED
Bugzilla old
People
(Reporter: jay, Assigned: tara)
Details
new_comment allows blank entries into the comment file. to forces something from the user, try this patch: (it also strings ^$ spaces). --- new_comment.cgi.ORIG Thu Oct 15 16:52:27 1998 +++ new_comment.cgi Thu Oct 15 18:01:45 1998 @@ -28,11 +28,20 @@ ($name, $value) = split(/=/, $pair); $value =~ tr/+/ /; + $value =~ s/^(\s*)//s; + $value =~ s/(\s*)$//s; $value =~ s/%([a-fA-F0-9][a-fA-F0-9])/pack("C", hex($1))/eg; $FORM{$name} = $value; } -open(COMMENTS, ">>data/comments"); $c=$FORM{"comment"}; +if ( (!defined $c) || ($c eq '') ) { + print "Content-type: text/html\n\n"; + print "<TITLE>Nothing on your mind?</TITLE>"; + print "<H1>Does you mind draw a blank?</H1>"; + exit 0; +} + +open(COMMENTS, ">>data/comments"); print COMMENTS $FORM{"comment"} . "\n"; close(COMMENTS); print "Content-type: text/html\n\n";
Comment 1•26 years ago
|
||
Reassigning to dmose@mozilla.org, who now has front-line responsibility for all Bonsai and Bugzilla bugs.
Comment 2•26 years ago
|
||
Reassigning back to me. That stuff about me no longer being the front-line person responsible for Bugzilla and Bonsai turned out to be short-lived. Please pardon our confusion, and I'm very sorry about the spam.
Updated•25 years ago
|
Status: NEW → ASSIGNED
Priority: P5 → P2
Comment 3•25 years ago
|
||
Actually, I'd like to completely re-write all the quip stuff.
Comment 4•25 years ago
|
||
tara@tequilarista.org is the new owner of Bugzilla and Bonsai. (For details, see my posting in netscape.public.mozilla.webtools, news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)
Assignee: terry → tara
Status: ASSIGNED → NEW
Assignee | ||
Comment 6•25 years ago
|
||
Happy fun patch...
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 7•24 years ago
|
||
per Terry, auto-verifying any resolved bug that hasn't been touched since before 2.10 was released.
Status: RESOLVED → VERIFIED
Comment 8•23 years ago
|
||
Moving to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
QA Contact: matty
Target Milestone: --- → Bugzilla old
Version: other → unspecified
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•