Closed
Bug 1105513
Opened 10 years ago
Closed 9 years ago
Add a NEON version for the new panning methods added for StereoPannerNode
Categories
(Core :: Web Audio, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: padenot, Assigned: dminor)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
No description provided.
|
Reporter | |
Comment 1•10 years ago
|
||
Specifically, AudioBlockPanStereoToStereo when aIsOnTheLeft is an array.
Summary: Add a NEON version for the new panning methods → Add a NEON version for the new panning methods added for StereoPannerNode
|
|
Reporter | |
Comment 2•10 years ago
|
||
This is good to have, but not of very high priority, the StereoPannerNode is not a very expensive node.
Priority: -- → P3
|
|
Reporter | |
Updated•9 years ago
|
Blocks: webaudioperf
|
Assignee | |
Comment 4•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28569/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28569/
Attachment #8700079 -
Flags: review?(padenot)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Besides the mochitests I ran this against the stereo panner benchmarks here [1]. I saw a 10-20ms average speedup compared to a fennec build without the patch applied.
[1] https://github.com/dminor/webaudio-benchmark/commit/57c83e50ac35bbad396bbdb93818ea14c146d6bb
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 6•9 years ago
|
||
Comment on attachment 8700079 [details]
MozReview Request: Bug 1105513 - Add a NEON version for AudioBlockPanStereoToStereo when aIsOnTheLeft is an array r=padenot
https://reviewboard.mozilla.org/r/28569/#review26147
::: dom/media/webaudio/AudioNodeEngineNEON.cpp:231
(Diff revision 1)
> + bool aIsOnTheLeft[WEBAUDIO_BLOCK_SIZE],
Make those `const` as well please.
::: dom/media/webaudio/AudioNodeEngineNEON.cpp:268
(Diff revision 1)
> + // bools are stored as a single byte.
That's an assumption we can make on ARM, iirc.
Attachment #8700079 -
Flags: review?(padenot) → review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8700079 [details]
MozReview Request: Bug 1105513 - Add a NEON version for AudioBlockPanStereoToStereo when aIsOnTheLeft is an array r=padenot
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28569/diff/1-2/
Attachment #8700079 -
Attachment description: MozReview Request: Bug 1105513 - Add a NEON version for AudioBlockPanStereoToStereo when aIsOnTheLeft is an array r?padenot → MozReview Request: Bug 1105513 - Add a NEON version for AudioBlockPanStereoToStereo when aIsOnTheLeft is an array r=padenot
|
||
Comment 9•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•