Started today with latest nightly, on all platforms affected tests: testCheckItemHighlight.js testSuggestHistory.js Affected line: http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/functional/testAwesomeBar/testCheckItemHighlight.js#l71 I could reproduce locally.

So before we had 2 autocomplete items, the Grants page for example in testCheckItemHighlight.js and a search item (at least in nightly from 3 days ago). Now, only the Grants page is present, the assert expects 2 items. I'll look for the changeset and provide a quick fix.

testSwitchToTab was also affected, different failure message but it was the same issue. We have 1 autocomplete item now and it was expecting more than 1 ("> 1"). http://mozmill-crowd.blargon7.com/#/functional/report/8ed3979adbcd8525966aaf10b001c61c

Comment on attachment 8529821 [details] [diff] [review] v1.patch Review of attachment 8529821 [details] [diff] [review]: ----------------------------------------------------------------- Ugh. This changed again? We need to find the regressor before amending this test since this was changed last month exactly in the opposite direction. I'm hesitant to change the test before knowing for sure this is a wanted change in Firefox and not a regression.

I totally agree with Andrei here! Also the test does not say which 2 items it expects exactly. We should start to add better explaining comments so it is easier to understand the behavior later in case of failures and regressions.

mc pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ced1402861b8&tochange=cef590a6f946 inbound pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=52f3f4a553a5&tochange=cef590a6f946 Seems to have come from fx-team, need to test a bit more builds.

Ugh, and on fx-team this came from mc: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=6e82407a7c65&tochange=679466398b30 Manual steps: 1. Open a tab 2. Type something in (preferably something that's not into the history). eg: "grants" Expected results: 3. Autocomplete Popup opens with "Default Action" selected (Google for "grants") Actual results: 3. Nothing happens Not sure if I messed something up with the regression (used mozregression). I'll cross check and see if I can find the regressor.

Ehh, bug 1105456 (and a couple followup bugs along with it). Indeed, unified autocomplete has been "temporarily disabled".

Marco, what's the plan for Unified Complete? Will it be reenabled on 37 after the merge? Or only when the found regressions are dealt with?

(In reply to Andrei Eftimie from comment #8) > Marco, what's the plan for Unified Complete? > Will it be reenabled on 37 after the merge? Or only when the found > regressions are dealt with? it depends on the timing and the patches complexity. if the regressions fixes will be simple and complete in the first couple weeks, we could uplift them to Aurora and re-enable it. Otherwise we will re-enable it only in Nightly. What we are doing for now is writing tests so that they check the unifiedcomplete pref and take different path based on that, or, they are disabled if unifiedcomplete gets disabled.

Comment on attachment 8529821 [details] [diff] [review] v1.patch Review of attachment 8529821 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Marko. I say we go forward with fixing our test for the time being to work without Unified Complete. We'll amend them again at a later date when it gets reenabled.

https://hg.mozilla.org/qa/mozmill-tests/rev/141db94ae219 (deafult)