Closed
Bug 1105976
Opened 10 years ago
Closed 10 years ago
[Stingray][Home] Add Folder structure and its data access methods
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S2 (19dec)
People
(Reporter: rexboy, Assigned: dwi2)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
We need to add folder structure to database. By discuss,
* The structure of folder would just like its parent card list.
* Add a "Folder" class directly that inherit from card class
* Folder objects save folder ID (maybe a UUID) pointing to real folder records in database.
Reporter | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.2 S2 (19dec)
Assignee | ||
Updated•10 years ago
|
Summary: [Stingray][Home] Add Folder structure to database → [Stingray][Home] Add Folder structure and its data access methods
Assignee | ||
Comment 1•10 years ago
|
||
Hi Rex,
Would you like to review the patch? Thanks
Attachment #8535502 -
Flags: review?(rexboy)
Assignee | ||
Comment 2•10 years ago
|
||
Our tests are under directory named '_test' because of the reason in https://bugzilla.mozilla.org/show_bug.cgi?id=1095219#c9
You could run them by rename '_test' to 'test' and run unit test as before.
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8535502 [details]
pull request
Looks good to me, but we need an explicit way for whom uses Folder to flush data into DB after updating. See my comment on Github.
Attachment #8535502 -
Flags: review?(rexboy)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8535502 [details]
pull request
Hi Rex,
I've addressed your comments. Now it will automatically write to data store every time we update folder contents.
Please help to review it again, thanks
Attachment #8535502 -
Flags: review?(rexboy)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8535502 [details]
pull request
Well, it's generally OK but I found a few small issues.
So please confirm comments on Github before landing.
Some of them are suggestions that you may consider but not blocking.
And also we should keep in mind that test cases are not fully covered yet.
Thanks for your work!
Attachment #8535502 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment addressed, waiting for Gaia-Try result
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=f5ae4ba7ca36
Assignee | ||
Comment 7•10 years ago
|
||
Landed on master
https://github.com/mozilla-b2g/gaia/commit/9259e0b236da1ae5fdb4fce0eac3e20617206534
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•