Closed Bug 1105976 Opened 10 years ago Closed 10 years ago

[Stingray][Home] Add Folder structure and its data access methods

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S2 (19dec)

People

(Reporter: rexboy, Assigned: dwi2)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

(deleted), text/x-github-pull-request
rexboy
: review+
Details
We need to add folder structure to database. By discuss, * The structure of folder would just like its parent card list. * Add a "Folder" class directly that inherit from card class * Folder objects save folder ID (maybe a UUID) pointing to real folder records in database.
Blocks: 1074084, 1076712
No longer blocks: CardUI
No longer depends on: 1074084, 1076712
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Target Milestone: --- → 2.2 S2 (19dec)
Summary: [Stingray][Home] Add Folder structure to database → [Stingray][Home] Add Folder structure and its data access methods
Attached file pull request (deleted) —
Hi Rex, Would you like to review the patch? Thanks
Attachment #8535502 - Flags: review?(rexboy)
Our tests are under directory named '_test' because of the reason in https://bugzilla.mozilla.org/show_bug.cgi?id=1095219#c9 You could run them by rename '_test' to 'test' and run unit test as before.
Comment on attachment 8535502 [details] pull request Looks good to me, but we need an explicit way for whom uses Folder to flush data into DB after updating. See my comment on Github.
Attachment #8535502 - Flags: review?(rexboy)
Comment on attachment 8535502 [details] pull request Hi Rex, I've addressed your comments. Now it will automatically write to data store every time we update folder contents. Please help to review it again, thanks
Attachment #8535502 - Flags: review?(rexboy)
Comment on attachment 8535502 [details] pull request Well, it's generally OK but I found a few small issues. So please confirm comments on Github before landing. Some of them are suggestions that you may consider but not blocking. And also we should keep in mind that test cases are not fully covered yet. Thanks for your work!
Attachment #8535502 - Flags: review?(rexboy) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: