Closed
Bug 1106007
Opened 10 years ago
Closed 9 years ago
[Bluetooth] Cleanup include guards
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
FxOS-S4 (07Aug)
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: ben.tian)
Details
Attachments
(1 file)
|
(deleted),
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
The include guards in Bluetooth's header files are inconsistent. They should be cleaned up according to [1].
[1] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style
|
Assignee | |
Comment 1•9 years ago
|
||
I leave header files under bluetooth1 unchanged since it will be obsolete.
Assignee: nobody → btian
Attachment #8642953 -
Flags: review?(tzimmermann)
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8642953 [details] [diff] [review]
[final] Patch 1: Cleanup bluetooth include guards, r=tzimmermann
Review of attachment 8642953 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks a lot!
Attachment #8642953 -
Flags: review?(tzimmermann) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8642953 -
Attachment description: Patch 1 (v1): Cleanup bluetooth include guards → [final] Patch 1: Cleanup bluetooth include guards, r=tzimmermann
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S4 (07Aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•