Robert Ginda Reporter
	Description • 23 years ago

371 NS_ASSERTION(elt, "No DOM element or node!");
372 PRBool hasTextEquivalent;
373 elt->HasAttribute(...);

Nonfatal assert, followed by a null pointer dereference.  This causes Venkman to
crash as soon as the window object is inspected.  If this doesn't get fixed on
the branch, every Venkman user will run into this crash.

	Aaron Leventhal Assignee
	Comment 2 • 23 years ago

Okay, can someone tell me how this happens?

There should aways be an <image> element for the node when this is called.

	Aaron Leventhal Assignee
	Comment 3 • 23 years ago

Comment on attachment 58246 [details] [diff] [review]
suggested pach

r=aaronl

	Brendan Eich [:brendan]
	Comment 4 • 23 years ago

Is this needed for 0.9.6?  Time is flying.

Why weren't more people cc'd on the bug?

/be

	Brendan Eich [:brendan]
	Comment 5 • 23 years ago

Comment on attachment 58246 [details] [diff] [review]
suggested pach

Anyone figure out why there is no dom element?

/be

	Christopher Blizzard (:blizzard)
	Comment 6 • 23 years ago

It would be nice to have, yes.  Is this the correct patch?

	Robert Ginda Reporter
	Comment 7 • 23 years ago

Yes this is important for 0.9.6 for the debugger.  I imagine that the dom
element  isn't there because this code isn't being reached through the expected
codepath.  The debugger is just enumerating properties on the window object, and
this code can't deal.

Sending drivers mail now.

	Christopher Blizzard (:blizzard)
	Comment 8 • 23 years ago

a=blizzard on behalf of drivers for 0.9.6

	Robert Ginda Reporter
	Comment 9 • 23 years ago

Checked into branch and trunk.

	gary_Cope
	Comment 10 • 23 years ago

Still seeing this on win98 2001112003 build.

Crashed when trying to inspect reference to 'this {window:388(?)}' in venkman
debugger.

	Robert Ginda Reporter
	Comment 11 • 23 years ago

Closing again.  The new issue is bug 112494.