:Hb Reporter
	Description • 10 years ago

When e10s is active always the Factory Build In Page Setup settings are used. The user can open the dialog, change some settings like Scale or Header&Footer and write this new values into the preferences. But Firefox don't work with this data.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 1 • 10 years ago

Hey Hb,

Can you give me some steps to reproduce? I'm not seeing "Factory Build" in the Page Setup dialog anywhere.

Thanks!

	Alice0775 White
	Comment 2 • 10 years ago

STR #1
1. open any web page
2. Open Print preview
3. Attempt to change Portrait/Landscape, Scale

Actual Results:
Nothing changed


STR #2
1. open any web page
2. Open Print Setup
3. Change Portrait/Landscape , Scale
4. Print

Actual Results:
Nothing changed

	:Hb Reporter
	Comment 3 • 10 years ago

(In reply to Mike Conley (:mconley) from comment #1)

I used the term "Factory Build In" for describing the default settings.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 4 • 10 years ago

Ah, yes - I understand now. Thank you!

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 7 • 9 years ago

Hb, are you still able to reproduce this on Nightly? I cannot based on the STR in comment 2 on Windows 7.

	:Hb Reporter
	Comment 8 • 9 years ago

Seems that this bug is gone now in Nightly.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 9 • 9 years ago

Ok, thank you!

	Brian Birtles (:birtles)
	Comment 10 • 9 years ago

Still broken for me on Windows 8.1 (details in bug 1176141).

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 11 • 9 years ago

Ok, yes, seeing this:

STR:

1) With e10s enabled, choose to print a page
2) In the printing properties, try to set the output to print in black and white
3) Kick off the print

ER:

The print should be in black and white.

AR:

The print is in full colour.

	Alice0775 White
	Comment 12 • 9 years ago

I can reproduce on Nightly42.0a1 with e10s, but not without e10s.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 13 • 9 years ago

Bug 1106321 - Serialize DEVMODE down to the content process when printing on Windows. r?jimm

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 14 • 9 years ago

Comment on attachment 8644591 [details]
MozReview Request: Bug 1106321 - Serialize DEVMODE down to the content process when printing on Windows. r?jimm

Bug 1106321 - Serialize DEVMODE down to the content process when printing on Windows. r?jimm

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 15 • 9 years ago

I have some try builds with this patch for people to test:

Win x86: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bind-autoland@mozilla.com-904a4b30af14/try-win32/firefox-42.0a1.en-US.win32.zip

Win x64: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bind-autoland@mozilla.com-904a4b30af14/try-win64/firefox-42.0a1.en-US.win64.zip

My local testing seems to indicate that the problem is fixed, but if the reporter (or Alice0775 White) could confirm, that'd be lovely. Thanks!

	Alice0775 White
	Comment 16 • 9 years ago

The try server fixes the problem of Comment 11.

https://hg.mozilla.org/try/rev/904a4b30af14
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 ID:20150807103901

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 17 • 9 years ago

That's great, thank you Alice0775!

	Jim Mathies [:jimm]
	Comment 18 • 9 years ago

Comment on attachment 8644591 [details]
MozReview Request: Bug 1106321 - Serialize DEVMODE down to the content process when printing on Windows. r?jimm

https://reviewboard.mozilla.org/r/15269/#review13905

::: widget/windows/nsPrintOptionsWin.cpp:75
(Diff revision 2)
> +    psWin->GetDevMode(&devMode); // Copies

if this copies why are we responsible for freeing it? I think you want to make clear here that this allocates? 

Also can you create a helper for doing the freeing? We have similar helpers down in xpcom - 

http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsWindowsHelpers.h

::: widget/windows/nsPrintOptionsWin.cpp:77
(Diff revision 2)
> +      // The maximum size of an IPC message. TODO: put this somewhere common?

IPCMessageUtils.h might be a good place for this. I don't think we should hardcode this here.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 19 • 9 years ago

Comment on attachment 8644591 [details]
MozReview Request: Bug 1106321 - Serialize DEVMODE down to the content process when printing on Windows. r?jimm

Bug 1106321 - Serialize DEVMODE down to the content process when printing on Windows. r?jimm

	Jim Mathies [:jimm]
	Comment 20 • 9 years ago

Comment on attachment 8644591 [details]
MozReview Request: Bug 1106321 - Serialize DEVMODE down to the content process when printing on Windows. r?jimm

https://reviewboard.mozilla.org/r/15269/#review14267

Ship It!

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 21 • 9 years ago

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/73dab35a83cd9161141da823877cc76ce03f958a
changeset:  73dab35a83cd9161141da823877cc76ce03f958a
user:       Mike Conley <mconley@mozilla.com>
date:       Thu Aug 06 17:36:54 2015 -0400
description:
Bug 1106321 - Serialize DEVMODE down to the content process when printing on Windows. r=jimm

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 22 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/73dab35a83cd

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 23 • 8 years ago
bugnotes

http://people.mozilla.org/~mconley2/bugnotes/bug-1106321.html