User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 Build ID: 20141126041045 Steps to reproduce: Go to Options -> Privacy. In the History group box, make sure "Remember history" is selected. Actual results: The links for "clear your recent history" and "remove individual cookies" have lost their style. There is no visual indicator that "clear your recent history" and "remove individual cookies" are selectable. Expected results: In versions of Firefox prior to 34.0, the "clear your recent history" and "remove individual cookies" links were properly styled, clearly indicating that they are selectable links.

Regression range: good=2014-08-26 bad=2014-08-27 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dc352a7bf234&tochange=0753f7b93ab7 Birunthan Mohanathas — Bug 1009370 - Part 1: Move .inline-link style from preferences.css to common.inc.css. r=Unfocused

[Tracking Requested - why for this release]:

Ken, could you please attach a screenshot of the bug and maybe another one for the expected look?

I attached a screenshot.

Thanks Loic. Your screenshots match the link style problem that I am seeing. It's very straightforward. The two links were previously styled to appear selectable, and now they are not. In my opinion, these links should be buttons, to make it clear that they can be clicked and that they will open new dialogs. For now, however, I'll be happy just to see the styled links restored.

This isn't a severe enough issue to fix in 34. I have tracked for other releases as I think that we should take the fix in 35+.

From #developers: [2014-12-15 10:22:50] * Archaeopteryx * Tomcat|sheriffduty: hi, do i need a try run for a m-c patch which only reverts some css removal? bug 1106792 [2014-12-15 10:26:51] * Tomcat|sheriffduty * Archaeopteryx: well depened if you think this is trivial and don't break any test then its fine

Can we get a nomination for uplift here? This needs to be nominated before Mon Dec 22 beta.

Comment on attachment 8537309 [details] [diff] [review] patch, v2, r=dao Thank you for the reminder. Approval Request Comment [Feature/regressing bug #]: Bug 1009370 [User impact if declined]: Links 'clear your recent history' and 'remove individual cookies' in the Privacy pane of the Preferences window (which we still use for beta and release) won't be recognizable as links [Describe test coverage new/current, TBPL]: Tested with nightly build [Risks and why]: minimal (only CSS changes which are reverts) [String/UUID change made/needed]: none

Comment on attachment 8537309 [details] [diff] [review] patch, v2, r=dao Approval Request Comment [Feature/regressing bug #]: Bug 1009370 [User impact if declined]: Links 'clear your recent history' and 'remove individual cookies' in the Privacy pane of the Preferences window (which we still use for beta and release) won't be recognizable as links [Describe test coverage new/current, TBPL]: Tested with nightly build [Risks and why]: minimal (only CSS changes which are reverts) [String/UUID change made/needed]: none

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 37.0a1 (buildID: 20141221030204).

https://hg.mozilla.org/releases/mozilla-aurora/rev/9283386f21ca https://hg.mozilla.org/releases/mozilla-beta/rev/d81ece962ab2

Verified fixed on latest DevEdition, build ID: 20141223004006.

Verified fixed on Firefox 35 Beta 8, buildID: 20141229214612.