Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Description • 10 years ago

+++ This bug was initially created as a clone of Bug #1106537 +++

Spinoff from bug 1106537 comment 5. Right now we build event regions for all "PAINTING" mode displaylist builders but we probably don't need to do it unless the root reference frame for the displaylist builder is also the root document root frame. I don't know which scenarios this occurs in though.

Probably it is this function that will need to change: http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.h?rev=b291989a1656#344

	Timothy Nikkel (:tnikkel)
	Comment 1 • 10 years ago

We should probably just change it to IsPaintingToWindow() instead of just painting mode.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 2 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/38537/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38537/

	Timothy Nikkel (:tnikkel)
	Comment 3 • 8 years ago

Comment on attachment 8727603 [details]
MozReview Request: Bug 1107143 - Don't build event regions unless we're painting to the window. r?tnikkel

https://reviewboard.mozilla.org/r/38537/#review35165

Wow, can't believe we didn't fix this sooner.

	Pulsebot
	Comment 4 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4aec1239d76

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 5 • 8 years ago

No noticeable talos impact from this change as far as I can tell. Wasn't really expecting any either, based on my local testing.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 6 • 8 years ago

Given that, no real point in uplifting this.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 7 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f4aec1239d76