Closed
Bug 1107308
Opened 10 years ago
Closed 10 years ago
Round dateAdded and lastModified values to milliseconds precision in places cpp components
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
People
(Reporter: asaf, Assigned: asaf)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 5 obsolete files)
|
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Comment 1•10 years ago
|
||
Note for whoever tackles this: if this is just rounding (123…6000), great. If it's a switch from microseconds to milliseconds, be sure to update Sync!
|
Assignee | |
Comment 2•10 years ago
|
||
just rounding for the time being.
|
|
Assignee | |
Comment 3•10 years ago
|
||
The goal here is to have the same precision in Bookmarks.jsm and the cpp components.
|
|
Assignee | |
Comment 4•10 years ago
|
||
toolkit xpcshell-tests pass. I still need to run the other tests suits, add a migration task and maybe document this behavior in the idl.
Attachment #8531899 -
Flags: feedback?(mak77)
|
|
Assignee | |
Updated•10 years ago
|
Iteration: --- → 37.1
Points: --- → 3
|
|
Assignee | |
Comment 5•10 years ago
|
||
document the new behavior.
MB also looks good.
Attachment #8531899 -
Attachment is obsolete: true
Attachment #8531899 -
Flags: feedback?(mak77)
Attachment #8531938 -
Flags: review?(mak77)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8531938 -
Attachment is obsolete: true
Attachment #8531938 -
Flags: review?(mak77)
Attachment #8532089 -
Flags: review?(mak77)
|
||
Updated•10 years ago
|
Flags: firefox-backlog+
|
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8532089 [details] [diff] [review]
with migration code
Review of attachment 8532089 [details] [diff] [review]:
-----------------------------------------------------------------
forgot to hg add the test
::: toolkit/components/places/tests/bookmarks/test_bookmarks.js
@@ +335,1 @@
> bs.setItemDateAdded(kwTestItemId, --dateAdded);
maybe you should remove the --?
Attachment #8532089 -
Flags: review?(mak77) → feedback+
|
|
Assignee | |
Comment 8•10 years ago
|
||
Attachment #8532089 -
Attachment is obsolete: true
Attachment #8532192 -
Flags: review?(mak77)
|
|
Assignee | |
Comment 9•10 years ago
|
||
Attachment #8532192 -
Attachment is obsolete: true
Attachment #8532192 -
Flags: review?(mak77)
Attachment #8532193 -
Flags: review?(mak77)
|
||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Flags: qe-verify?
|
|
Assignee | |
Comment 10•10 years ago
|
||
Attachment #8532193 -
Attachment is obsolete: true
Attachment #8532193 -
Flags: review?(mak77)
Attachment #8532208 -
Flags: review?(mak77)
|
|
Assignee | |
Updated•10 years ago
|
Flags: qe-verify? → qe-verify-
|
|
||
Comment 11•10 years ago
|
||
Comment on attachment 8532208 [details] [diff] [review]
patch
Review of attachment 8532208 [details] [diff] [review]:
-----------------------------------------------------------------
nit: for additional testing and safety, in debug mode, just before shutdown, we could:
SELECT 1 FROM moz_bookmarks WHERE dateAdded % 1000 > 0 OR lastModified % 1000 > 0 LIMIT 1
we are doing something similar to detect missing guids in #ifdef DEBUG
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/Database.cpp#1549
This would allow us to detect eventual missing conversions and could be useful when in future we move to real ms timestamps.
Attachment #8532208 -
Flags: review?(mak77) → review+
|
|
||
Updated•10 years ago
|
Iteration: 37.1 → 37.2
|
|
||
Comment 12•10 years ago
|
||
also, could you please file a follow-up to do the same rounding in all of the tables?
|
|
Assignee | |
Comment 13•10 years ago
|
||
|
|
Assignee | |
Comment 14•10 years ago
|
||
Filed bug 1110042.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•