Closed Bug 1107438 Opened 10 years ago Closed 10 years ago

[e10s] page-mod add-on exception on onAttach: TypeError: can't convert undefined to object

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(e10s+)

Status:
RESOLVED FIXED
Milestone:
mozilla37
Tracking Flags:
Tracking Status
e10s + ---

People

(Reporter: marc.chevrier, Assigned: zombie)

References

Details

Attachments

(2 files)

page-mod problem in e10s mode
(deleted), application/x-xpinstall
Details
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1800
(deleted), text/x-github-pull-request
mossop
: review+
Details
Attached file page-mod problem in e10s mode (deleted) — 
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141126041045

Steps to reproduce:

launch Firerox Nighlty (37.0a1) with e10s activated
install a small add-on (see attachement)
exit Firefox
re-launch Firefox


Actual results:

on second Firefox launch, errors in console:
TypeError: can't convert undefined to object
Stack trace:
getFrames@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/window/utils.js:386:10
applyOnExistingDocuments/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/page-mod.js:196:7
applyOnExistingDocuments@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/page-mod.js:189:3
PageMod@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/page-mod.js:148:7
@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/disposable.js:48:56
dispatch@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/method/core.js:119:12
Disposable<.initialize@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/disposable.js:69:17
constructor@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/heritage.js:146:23
exports.main@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://pagemod_bug-at-markapola/sdk_pagemod_bug/lib/main.js:6:1
run@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/addon/runner.js:151:1
startup/</<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/addon/runner.js:86:7
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
 runner.js:164
TypeError: can't convert undefined to object
Stack trace:
getFrames@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/window/utils.js:386:10
applyOnExistingDocuments/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/page-mod.js:196:7
applyOnExistingDocuments@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/page-mod.js:189:3
PageMod@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/page-mod.js:148:7
@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/disposable.js:48:56
dispatch@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/method/core.js:119:12
Disposable<.initialize@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/disposable.js:69:17
constructor@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/heritage.js:146:23
exports.main@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://pagemod_bug-at-markapola/sdk_pagemod_bug/lib/main.js:6:1
run@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/addon/runner.js:151:1
startup/</<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/I051466/AppData/Roaming/Mozilla/Firefox/Profiles/zcg69sb4.Nightly/extensions/pagemod_bug@markapola.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/addon/runner.js:86:7
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
 Promise-backend.js:873



Expected results:

No error in console.
Can you take a look at this zombie?
Flags: needinfo?(tomica+amo)
Blocks: 1047257
(In reply to Dave Townsend [:mossop] (Out till December 1st) from comment #1)
> Can you take a look at this zombie?

sure
Assignee: nobody → tomica+amo
Flags: needinfo?(tomica+amo)
tracking-e10s: --- → +
Summary: [e10s] page-mod crash on onAttach → [e10s] page-mod exception ("TypeError: can't convert undefined to object") on onAttach
Summary: [e10s] page-mod exception ("TypeError: can't convert undefined to object") on onAttach → [e10s] page-mod add-on exception on onAttach: TypeError: can't convert undefined to object
Any progress here yet? I'm seeing this with the 1Password add-on too
Flags: needinfo?(tomica+amo)
i'm working on selection now, and this is next in line.

i looked at it quickly though, and i think it's a simple wait for the right event before initialization.
Flags: needinfo?(tomica+amo)
(In reply to Tomislav Jovanovic [:zombie] from comment #4)
> i think it's a simple wait for the right event before initialization.

it turned out even simpler than that
Attachment #8544043 - Flags: review?(dtownsend)
Blocks: e10s-sdk, 1066685
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8544043 - Flags: review?(dtownsend) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/195cc0836445fd9b228c4972da41dbcec7d299cf
bug 1107438 - check contentWindow exists on startup with e10s

https://github.com/mozilla/addon-sdk/commit/9eae76ef5f5f0b6745215e19b6a553d0eed90f51
Merge pull request #1800 from zombie/1107438-pagemod-startup

bug 1107438 - check contentWindow exists on startup with e10s, r=@Mossop
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: