https://reviewboard.mozilla.org/r/1137/diff/ So the files all show up, but they all have "This is a binary file. The content cannot be displayed." and "New Change". Which is unhelpful. A bunch of the files were deleted, some of them were moved from Windows to shared, some (particularly the hidpi ones) from OS X to shared.

To be clear, splinter is worse here in that it starts making up renames which don't exist... ( https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1104730&attachment=8528378 )

We should probably look into this ASAP

In my case for non-binary files, I get a deletion of the old file and and addition of a new file instead of seeing a comparison of what changed: https://reviewboard.mozilla.org/r/1431/diff/

Is this bug about (any) file renames or about the specific case of binary files? because comment 3 is real and needs to be addressed, which bears the question whether a separate bug should be filed.

(In reply to Mike Hommey [:glandium] from comment #6) > Is this bug about (any) file renames or about the specific case of binary > files? because comment 3 is real and needs to be addressed, which bears the > question whether a separate bug should be filed. I will be fixing all renames as part of this bug, no need to file another.

Fixed by Bug 1161791

I don't believe this is fixed. https://reviewboard.mozilla.org/r/10955/diff/1#index_header has file moves when I pull it from hg-reviewboard, but online it still shows up as add/removes.

(In reply to Benjamin Smedberg [:bsmedberg] from comment #10) > I don't believe this is fixed. > https://reviewboard.mozilla.org/r/10955/diff/1#index_header has file moves > when I pull it from hg-reviewboard, but online it still shows up as > add/removes. Thanks for reporting this Benjamin. This should definitely be working - looking at the RB database it appears that the updates to our hg extensions weren't deployed to the reviewboard-hg server. Greg, could you check if reviewboard-hg is using a stale vct? if so could you please deploy?

Deployed to reviewboard-hg.

This should actually be fixed now - it will however only be fixed for pushes going forward.

Bug 1107547 - Verify renames show up

Verified it works.