Closed
Bug 1107774
Opened 10 years ago
Closed 10 years ago
Make LIRGenerator visit() methods infallible
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Similarly to bug 1106947, during lowering if we encounter an OOM (typically due to running out of virtual registers), the MIR generator can be flagged and the compilation aborted shortly afterwards, rather than requiring explicit error checking throughout the lowering phase.
Attachment #8532318 -
Flags: review?(jdemooij)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8532318 [details] [diff] [review]
patch
Review of attachment 8532318 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for the delay. Nice cleanup.
Attachment #8532318 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 3•10 years ago
|
||
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•