Closed Bug 110779 Opened 23 years ago Closed 23 years ago

Implement prefs for saving related files and publishing

Categories

(SeaMonkey :: Composer, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0

People

(Reporter: Brade, Assigned: cmanske)

References

Details

(Whiteboard: FIX IN HAND)

Attachments

(1 file, 4 obsolete files)

This bug should cover the UI changes needed to save related files. Robin--Charley will need a string to go next to the checkbox. What the checkbox will turn on/off is whether extra files (JS, CSS, images, etc.) are saved with the html document being edited when the file is saved for the first time or when saved to a new location (save as is triggered).
Is this new UI under Edit|Preferences|Composer|General:When Saving Files ? Or, does it relate specifically to publishing? Can you describe a typical example of when this would be used and also when you wouldn't want to use it? Thanks.
While this is essential for publishing, it does apply to the "Save As" command, right, Kathy? But doesn't that implementation have to be done by (or at least invovle) the browser team as it applies to all modules using "Save As"? They already have a bug on that issue, don't they?
Summary: implement UI in prefs for saving related files → Implement UI in prefs for saving related files
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
Whiteboard: PUBLISHING, EDITORBASE
Do we have a tracking bug for all publishing tasks?
Whiteboard: PUBLISHING, EDITORBASE → PUBLISHING
Blocks: 28792
moving milestone
Target Milestone: mozilla0.9.8 → mozilla0.9.9
It's unclear what level of support we can have for individual files, but we will at least let the user decide whether or not to upload all the associated files and what directory to put them in at the destination location.
Keywords: nsbeta1+
Target Milestone: mozilla0.9.9 → mozilla1.0
We support letting the user designate one subdirectory within a site to place image an other associted files. Keeping this bug open to improve this in the future for individual file control.
Keywords: nsbeta1+
Target Milestone: mozilla1.0 → mozilla1.2
readd nsbeta1+ and reset milestone back to 1.0 This bug is NOT related to publishing. This is a checkbox for prefs so the user will have the choice of getting related pieces (images, css, js, etc.) when saving a file that was remote to a local disk (or from one local disk to another local disk). Please re-read the original description.
Keywords: nsbeta1+
Whiteboard: PUBLISHING
Target Milestone: mozilla1.2 → mozilla1.0
Expanding this to cover the two simple prefs I need to implement for saving and publishing.
Summary: Implement UI in prefs for saving related files → Implement prefs for saving related files and publishing
Attached patch patch v1 (obsolete) (deleted) — Splinter Review
Attached patch patch v2 (obsolete) (deleted) — Splinter Review
Forget the new strings in dtd file
Attachment #76325 - Attachment is obsolete: true
Whiteboard: FIX IN HAND, need r=,sr=
Comment on attachment 76326 [details] [diff] [review] patch v2 Looks fine. I was a little confused about the code that brings up the dialog, not noticing that it was modal and therefore won't return from openDialog() until the user has dismissed the dialog. Might not hurt to comment that, but it's your choice. I haven't had a chance yet to try it on Unix and verify that the prefs panel looks okay, but I will. r=akkana
Attachment #76326 - Flags: review+
On the issue of: + // XXX This doesn't work!!! GetDocumentURI is in nsEditorShell.cpp, but not in IDL It was a simple problem. The call should be: var oldLocation = GetDocumentUrl(); and everything works fine.
Comment on attachment 76326 [details] [diff] [review] patch v2 sr=hewitt
Attachment #76326 - Flags: superreview+
Comment on attachment 76326 [details] [diff] [review] patch v2 a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #76326 - Flags: approval+
Whiteboard: FIX IN HAND, need r=,sr= → FIX IN HAND, approved
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: FIX IN HAND, approved
the prefs are in...verified in 3/27 build however, the Save pref does not work. I did a File | Edit Page on www.abcnews.com and then I did a Save As to my desktop...I got images everywhere... Charley confirms this and he's gonna file a bug..
Status: RESOLVED → VERIFIED
Code to use the "saveAssociatedFiles" pref in ComposerCommands.js doesn't work right if pref is set false. Reopening.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Attached patch Fix (obsolete) (deleted) — Splinter Review
Don't save associated files if "save_associated_files" pref is "false'
Attachment #76326 - Attachment is obsolete: true
Status: REOPENED → ASSIGNED
Whiteboard: FIX IN HAND, need r=,sr=
This patch has 2 versions: 2nd is identical fix, just uses -w to show just the lines changed, not indent changes.
Attached patch Fix v2 (obsolete) (deleted) — Splinter Review
Update: use IOService to create new URI object
Attachment #76585 - Attachment is obsolete: true
Attached patch Fix v3 (deleted) — Splinter Review
One more simplification in if...else blocks per reviewer comments.
Attachment #76616 - Attachment is obsolete: true
Comment on attachment 76630 [details] [diff] [review] Fix v3 r=brade
Attachment #76630 - Flags: review+
Whiteboard: FIX IN HAND, need r=,sr= → FIX IN HAND, need approval
Comment on attachment 76630 [details] [diff] [review] Fix v3 sr=alecf
Attachment #76630 - Flags: superreview+
Comment on attachment 76630 [details] [diff] [review] Fix v3 a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #76630 - Flags: approval+
Whiteboard: FIX IN HAND, need approval → FIX IN HAND, approved
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
Whiteboard: FIX IN HAND, approved → FIX IN HAND
verified in 4/2 trunk build.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: