Currently a very similar dialog is used for chosing a cert to be used for requested client authentication, and for misc. preferences where a prefered certificate needs to be configured. Both dialogs have a different appearance currently - the client authentication dialog displays additional information text. That space is not required and not contained in the cert picker used for cert preference configuration. It would be nice to combine both dialogs into one shared implementation, which can behave as both appearances.

P2. I agree. How much work is that?

The actual coding can be done really quick, sounds like it could be done in 1-2 hours.

I wonder whether it is worth it to work on this. Maybe currently the only difference between both dialogs is the additional information in the upper area, but this will change soon. If you look at the S/Mime UI design, it is suggested the cert picker to configure a certificate to be used will change, because it should contain additional buttons. I am not sure what is better. I tend to prefer the two separate independent implementations. We now have the advantage that the code is simple. With a shared implementation, it would be cluttered with code to hide or show UI elements, as the current situation requires it. And the number of parameters that are passed to the dialog are currently different, making the combined code more complex. And I want to delay work on this bug at least until bug 110420 has been resolved, because the patches I'd create would contain conflicts.

I think this is no longer reasonable, because both dialogs behave differently, and those portions that can be shared are shared already. Marking wontfix.

Verified.