From the investigation in bug 1098437, it turns out I regressed this in 35 with bug 973001. Impact of the bug: - the Stop sharing UI doesn't work - we are leaking the <browser> of the window were the tab lived before being teared off.

[Tracking Requested - why for this release]: regression with possible privacy implications.

Turned out the "Stop sharing" action wasn't the only broken piece of the WebRTC UI after swapping tabs between windows. The "Allow" and "Deny" actions were also broken if a tab had been swapped with a pending gUM request.

Comment on attachment 8533914 [details] [diff] [review] Fix Review of attachment 8533914 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/modules/webrtcUI.jsm @@ +73,5 @@ > + swapBrowserForNotification: function(aOldBrowser, aNewBrowser) { > + this._streams.forEach(stream => { > + if (stream.browser == aOldBrowser) > + stream.browser = aNewBrowser; > + }); for (let .. of ..) instead of closure?

Comment on attachment 8533914 [details] [diff] [review] Fix Approval Request Comment [Feature/regressing bug #]: bug 973001 [User impact if declined]: Impossible to stop sharing a camera/microphone in a detached tab. Serious privacy issue. [Describe test coverage new/current, TBPL]: Already on mozilla-central. [Risks and why]: acceptable, compared to the regression. [String/UUID change made/needed]: none.

The patch here doesn't apply cleanly on mozilla-beta because bug 1095733 landed on 36 and isn't on 35.

(In reply to Florian Quèze [:florian] [:flo] from comment #7) > The patch here doesn't apply cleanly on mozilla-beta because bug 1095733 > landed on 36 and isn't on 35. Florian -- Does it make sense for me to ask for uplift on bug 1095733 to Fx35?

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #8) > (In reply to Florian Quèze [:florian] [:flo] from comment #7) > > The patch here doesn't apply cleanly on mozilla-beta because bug 1095733 > > landed on 36 and isn't on 35. > > Florian -- Does it make sense for me to ask for uplift on bug 1095733 to > Fx35? I've unbitrotted my patch and landed it on beta anyway. For bug 1095733 that's up to you, but it doesn't seem to be a regression fix, so I wouldn't request uplift if it was my patch.

Verified fixed FF 36.0a2 (2014-12-15), 37.0a1 (2014-12-14) Win 7

Verified fixed FF 35b4 Win 7

I think this bug fix may have created this one: https://bugzilla.mozilla.org/show_bug.cgi?id=1122036 Any ideas on why isn't set notification.browser.messageManager on a Panel?