Closed
Bug 11080
Opened 25 years ago
Closed 21 years ago
news "spoiler" feature
Categories
(MailNews Core :: Backend, defect, P3)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: sspitzer, Assigned: mnyromyr)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
this is something alecf told me about a while back.
basically, if a news message has a certain sequence of characters, the message
should be displayed with a button. clicking on the button shows the rest of the
message.
it's called the surprise feature or something.
Alec - can you elaborate on this? What type of sequence of characters? Why
would someone want this feature?
Reporter | ||
Updated•25 years ago
|
Summary: [HELP WANTED] news "surprise" feature → [HELP WANTED] news "spoiler" feature
Target Milestone: M15
Reporter | ||
Comment 2•25 years ago
|
||
marking m15.
let me explain the feature a little more:
there would be a message, like this:
Q: Why did the chicken cross the road?
\r
A: To get to the other side
When viewed, the A: part would be hidden and there would be button (or
something) that when clicked would show the whole message.
renaming the summary to be "spoiler", as that is what it's called.
Reporter | ||
Updated•25 years ago
|
Whiteboard: HELP WANTED
Comment 3•25 years ago
|
||
we should use the same twisty icon that we use when a mail message has many
recipients to show/hide the recipient list.
Adding rhp to the list because this is really a libmime feature.
Rich, the way seth and I were thinking about this was to basically have a
"surprise counter" in libmime that would determine how many surprises to
display. Each surprise twisty would have an index, when you click on the twisty,
it would look like:
if (twisty.closed)
surpriseCounter = twisty.index+1;
else
surpriseCounter = twisty.index
reflow()
then libmime would basically display messages as it normally did, but if it
encountered a twisty, it would do something like:
message.surpriseCount++;
if (surpriseCounter <= message.surpriseCount)
abortRestOfMessage();
Reporter | ||
Comment 4•25 years ago
|
||
this should be obvious, but this is a LOW priority feature. way low.
Comment 5•25 years ago
|
||
Bulk-resolving requests for enhancement as "later" to get them off the Seamonkey
bug tracking radar. Even though these bugs are not "open" in bugzilla, we
welcome fixes and improvements in these areas at any time. Mail/news RFEs
continue to be tracked on http://www.mozilla.org/mailnews/jobs.html
Comment 6•25 years ago
|
||
Reopen mail/news HELP WANTED bugs and reassign to nobody@mozilla.org
Comment 7•25 years ago
|
||
The sequence of characters in question is ^L (that is, Control+L). See
http://www.deja.com/getdoc.xp?AN=524344854&fmt=text for a nice
discussion about its support in other newsreaders. There's no reason
it shouldn't apply to e-mail as well as Usenet, of course.
The usual case is someone talking about a movie or whatever on Usenet,
who doesn't want to annoy those who haven't seen/read it yet. The
lowest-common-denominator solution is to insert lots of blank lines
(liberally marked with `SPOILER SPACE'), so people have to scroll to
see it. ^L is the, uh, more sophisticated solution.
-- mpt
Updated•25 years ago
|
Keywords: helpwanted
Updated•25 years ago
|
Summary: [HELP WANTED] news "spoiler" feature → news "spoiler" feature
Whiteboard: HELP WANTED
Target Milestone: M15
Comment 8•25 years ago
|
||
There should be some easy way of adding a spoiler mark when composing a message,
too. But that's another bug.
Comment 9•25 years ago
|
||
BTW, spoiler insertion in composition is now Bug #27153.
Also, I wonder how this would affect HTML mail. What happens if there's a ctrl-L
character inside a block element (like <P>, <DIV>, <BLOCKQUOTE>)? Would this
cause a problem with layout?
Comment 10•25 years ago
|
||
I have a "spoiler" page, which shows how various newsreaders support the spoiler
char: <http://www.newsreaders.com/spoilers/> (I make no claims as to the
completeness of the list).
John Moreno
Comment 12•24 years ago
|
||
> Also, I wonder how this would affect HTML mail.
> What happens if there's a ctrl-L
> character inside a block element (like <P>, <DIV>,
> <BLOCKQUOTE>)? Would this
> cause a problem with layout?
The form feed character is defined as white space in HTML, and should be
treated as such. In XHTML (XML), the form feed character is forbidden.
Comment 13•23 years ago
|
||
*** Bug 85726 has been marked as a duplicate of this bug. ***
Comment 14•23 years ago
|
||
Comment 15•23 years ago
|
||
That's right.
Comment 16•23 years ago
|
||
Yep. I'm not sure how likely 27153 is, as the most useful way of adding
the ability to insert it is via a menu, and it's my understanding that there is
some reluctance to add them. It almost certainly won't get added until
after this bug is fixed.
PS -- 14 messages with a spoiler char in rasfw on Sep 6.
Comment 17•23 years ago
|
||
See also bug 66822.
Comment 18•23 years ago
|
||
66822 is only tangentially related. It's unlikely that it would have any impact
on this bug, or vice versa. Yes, rot13 is sometimes used to hide spoiler text,
but otherwise it's an unrelated feature.
Assignee | ||
Comment 19•21 years ago
|
||
Taking.
In <c1ik5m$1j9h0d$1@ID-14284.news.uni-berlin.de> (sorry, in German) I have
outlined a possible solution which I'm willing to modify for use within MailNews.
Status: NEW → ASSIGNED
Assignee | ||
Updated•21 years ago
|
Assignee: nobody → mnyromyr
Status: ASSIGNED → NEW
Comment 20•21 years ago
|
||
Karsten, the code would probably be the plaintext converter, probably the
generic one, in netwerk/streamconv/converters/mozTXTToHTMLConv, function
GlyphHit, somewhere around "// x^2 -> sup".
I'd either
- just replace the spoiler with <div class="moz-txt-formfeed">, plus CSS that
inserts 100% height *before* the tag
- use alecf's proposal of using grippies, if possible, but then you definitely
need sensibly positioned </div> tags.
Note that you can't use JavaScript, I think, it's usually disabled and the doc
you produce is content, not chrome.
Assignee | ||
Comment 21•21 years ago
|
||
Just turn the spoiler space denoting character ^L (aka \f aka FF) into a <div>
with the new class moz-txt-formfeed and style its height to 100%, thus creating
an empty page within the respective <browser>.
This pattern translation is part of the kGlyphSubstitution.
Assignee | ||
Updated•21 years ago
|
Attachment #142267 -
Flags: review?(ben.bucksch)
Comment 22•21 years ago
|
||
Comment on attachment 142267 [details] [diff] [review]
Very simple patch that turn ^L into an empty page
r=BenB
I'd prefer the Twisties, but it seems they're much harder, given that libmime
feeds the converter line by line.
Attachment #142267 -
Flags: review?(ben.bucksch) → review+
Comment 23•21 years ago
|
||
Comment on attachment 142267 [details] [diff] [review]
Very simple patch that turn ^L into an empty page
Actually, the FF char is potentially inline, as shown by the examples, so maybe
use a span in the konverter and turn it into a display: block in the
stylesheet. (No need a for a new patch, you can do what while checking in.)
Thanks for the patch, Karsten!
Assignee | ||
Updated•21 years ago
|
Attachment #142267 -
Flags: superreview?(mscott)
Comment 24•21 years ago
|
||
Let me add my thanks for the patch, Karsten: Thanks! I hope it gets checked in soon.
Assignee | ||
Updated•21 years ago
|
Attachment #142267 -
Flags: superreview?(mscott) → superreview?(bienvenu)
Updated•21 years ago
|
Attachment #142267 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 25•21 years ago
|
||
Attachment #142267 -
Attachment is obsolete: true
Comment 26•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•21 years ago
|
Keywords: helpwanted
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•