Closed
Bug 1108345
Opened 10 years ago
Closed 10 years ago
Pentadactyl crashes when using Firefox 35 [@ js::ToBooleanSlow(JS::Handle<JS::Value>) ]
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: fayolle-florent, Unassigned)
References
Details
(Keywords: regression)
Crash Data
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0 Build ID: 20141201162954 Steps to reproduce: 1. Install this version of the Pentadactyl addon (latest nightly of pentadactyl with the maxVersion of the install.rdf file modified) 2. Put the .pentadatylrc this file in your home ($HOME on Linux) 3. Restart Firefox 4. Open two tabs 5. Use Shift-H Actual results: Firefox crashes Expected results: The user should switch to another tab. Florent
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
The crash report is given here: https://crash-stats.mozilla.com/report/index/8e92421a-36f5-4be1-a3a3-e2c622141207 Kris: I took the liberty to cc you since I know you are one of the maintainer of the addon. Florent
Comment 3•10 years ago
|
||
Is this something that the JS engine should own?
Component: General → JavaScript Engine
Flags: needinfo?(bhackett1024)
Updated•10 years ago
|
Crash Signature: [@ js::ToBooleanSlow(JS::Handle<JS::Value>) ]
Summary: Pentadactyl crashes when using Firefox 35 → Pentadactyl crashes when using Firefox 35 [@ js::ToBooleanSlow(JS::Handle<JS::Value>) ]
Comment 4•10 years ago
|
||
It's crashing in JS, yeah. Can you reproduce this? Is there a blame cset?
Updated•10 years ago
|
Flags: needinfo?(bhackett1024)
Reporter | ||
Comment 5•10 years ago
|
||
Brian, who are you asking that question? (the needinfo flag is unset) I can bisect the regression using mozregression to get a date of a nightly, but I can't bisect more if I have to compile. Are you interested? Florent
Flags: needinfo?(bhackett1024)
Comment 6•10 years ago
|
||
Getting it down to a particular Nightly would be a good first step.
Keywords: regressionwindow-wanted
Updated•10 years ago
|
Flags: needinfo?(bhackett1024)
Reporter | ||
Comment 7•10 years ago
|
||
> Getting it down to a particular Nightly would be a good first step.
OK, will do that.
Florent
Reporter | ||
Updated•10 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Reporter | ||
Comment 8•10 years ago
|
||
Oops, sorry, wrong modifications... Florent
OS: All → Linux
Hardware: All → x86_64
Reporter | ||
Comment 9•10 years ago
|
||
The regression occurred in the nightly of 2014-09-16. I will continue bisecting tomorrow, but here is a regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d295c8ec&tochange=bb579e3d Oddly, in that link, there are commits of Wed Sep 17. Is that normal? Florent
Reporter | ||
Comment 10•10 years ago
|
||
Here is a tinier range of commits: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ed5f95178615&tochange=fada58fb0996 Florent
Comment 11•10 years ago
|
||
[Tracking Requested - why for this release]: regression
Blocks: 1001090
Status: UNCONFIRMED → NEW
status-firefox34:
--- → unaffected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
tracking-firefox35:
--- → ?
tracking-firefox36:
--- → ?
tracking-firefox37:
--- → ?
Ever confirmed: true
Flags: needinfo?(shu)
Keywords: regressionwindow-wanted → regression
Comment 12•10 years ago
|
||
Needinfo is to look at this bug and see if this is something for the JS team to fix or is the extension doing something bad?
Updated•10 years ago
|
Comment 13•10 years ago
|
||
I can't reproduce this with STR on Nightly, and I see this message during loading. pentadactyl: Loading base: TypeError: iter[Symbol.iterator] is not a function pentadactyl: bootstrap: TypeError: iter[Symbol.iterator] is not a function map@resource://dactyl/bootstrap.jsm -> resource://dactyl/base.jsm:1622:1 toObject@resource://dactyl/bootstrap.jsm -> resource://dactyl/base.jsm:1563:17 iterProto[k]@resource://dactyl/bootstrap.jsm -> resource://dactyl/base.jsm:1869:19 deprecated@resource://dactyl/bootstrap.jsm -> resource://dactyl/base.jsm:331:31 @resource://dactyl/bootstrap.jsm -> resource://dactyl/base.jsm:1900:1 loadSubScript@resource://dactyl/bootstrap.jsm:20:26 _load@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/shu/moz/central/obj-dbg/tmp/scratch_user/extensions/pentadactyl@dactyl.googlecode.com.xpi!/bootstrap.js:137:17 load@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/shu/moz/central/obj-dbg/tmp/scratch_user/extensions/pentadactyl@dactyl.googlecode.com.xpi!/bootstrap.js:160:17 init@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/shu/moz/central/obj-dbg/tmp/scratch_user/extensions/pentadactyl@dactyl.googlecode.com.xpi!/bootstrap.js:261:25 startup@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/shu/moz/central/obj-dbg/tmp/scratch_user/extensions/pentadactyl@dactyl.googlecode.com.xpi!/bootstrap.js:366:13 XPI_callBootstrapMethod@resource://gre/modules/addons/XPIProvider.jsm:4436:9 XPI_startup@resource://gre/modules/addons/XPIProvider.jsm:2160:13 callProvider@resource://gre/modules/AddonManager.jsm:208:12 _startProvider@resource://gre/modules/AddonManager.jsm:667:5 AMI_startup@resource://gre/modules/AddonManager.jsm:821:9 AMP_startup@resource://gre/modules/AddonManager.jsm:2399:5 AMC_observe@file:///home/shu/moz/central/obj-dbg/dist/bin/components/addonManager.js:55:7 So I guess it's not loading the xpi. Let me build beta I guess...
Comment 14•10 years ago
|
||
The crash is caused by not backporting bug 1077949. I rolled up a patch and requested backport in that bug. Note that while that fixes the crash, the addon needs to be fixed as well. It has a temporal dead zone violation (accessing a 'let' binding before initializing it).
Flags: needinfo?(shu)
Comment 16•10 years ago
|
||
Fixed in bug 1077949, resolving this bug. The issues with the addon should be tracked by that addon developer.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•