Closed Bug 110835 Opened 23 years ago Closed 19 years ago

Rename members of BITMAPINFOHEADER and BITMAPFILEHEADER

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: Biesinger, Assigned: netdragon)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch that works with latest CVS
(deleted), patch
pavlov
: review+
Details | Diff | Splinter Review
Members of the two mentioned structs should use the same names that Microsoft uses in its header files.
Attached patch Suggested Patch (obsolete) (deleted) — — Splinter Review
pavlov, could you please review this patch?
Status: NEW → ASSIGNED
Attachment #58431 - Attachment is obsolete: true
Chris: I am going to include a fix for this bug in my RLE patch.
Oh sorry... Therefore its not necessary to review this atm.
Comment on attachment 58523 [details] [diff] [review] Patch that works with latest CVS sure. r=pavlov
Attachment #58523 - Flags: review+
In my patch (I'm still writing) I followed Microsoft's naming convention except for two things: 1) Instead of BITMAPINFOHEADER I used BitmapInfoHeader to follow the ns coding style 2) replaced DWORDs, BYTEs, and WORDs
Marking as dependant on bug 108271, because netdemon's patch for that bug will fix this one.
Depends on: bmprle
marking as new again
Status: ASSIGNED → NEW
Keywords: review
Target Milestone: --- → Future
reassign to netdemon, since it's his patch in bug 108271 that will fix this bug
Assignee: cbiesinger → netdemonz
Is this still valid, or can we mark this one closed by bug 108271?
I don't really care about this bug either way, do with it what you want :)
Marking fixed by 108271.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: