Environment: Device: Samsung Galaxy S4 (Android 4.4.2); Build: Nightly 37.0a1 (2014-12-08); Steps to reproduce: 1. Go to device 'Date and Time' settings. 2. Manually change the timezone to GMT-8:00 (Pacific Standard Time); 3. Launch Fennec with a clean profile; 4. Tap on the URL bar and search for a therm (e.g. "mozilla"); 5. Observe that the search is made with Yahoo search engine; 6. Go to Settings -> Customize -> Search. Expected result: The default search engine is Yahoo. Actual result: The default search engine appears to be Amazon.com even if the search results from step 5 are from Yahoo.

Changing the timezone has no relevance. I can reproduce this regardless. It looks like amazon.com is claimed as default but is not actually the default.

No search required. [Tracking Requested - why for this release]: Listed search default not accurate; not actually default though

Well it does have something related to the timezone, because setting the timezone to GMT +2:00(my locale) will display the correct default search engine.

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cef590a6f946&tochange=17de0f463944 Going with bug 1102416 gsharp@mozilla.com Fri Nov 28 19:01:04 2014 +0000 17de0f463944 Gavin Sharp — Bug 1102416: make Yahoo the default search plugin for en-US in American time zones, r=dolske, a=me

[Tracking Requested - why for this release]: My patch for bug 1102416 broke this in Fennec. We may want to fix this in Firefox 34 (Fennec-only).

Nightly (12/08) under new profiles e.g, EST (Toronto) Nightly specifies Amazon.com (default); alphabetical order - actual default when searching is Yahoo. EEST (Cairo) Nightly specifies Yahoo (default), actual default when searching is Yahoo

Pushed a possible patch to Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1bb27213c727

(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #7) > Pushed a possible patch to Try: > https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1bb27213c727 With this build I see the correct specified default in our search settings

The core issue is that Fennec uses the search service in different ways than Firefox, and so bug 1102416 comment 5 doesn't apply. This effectively makes bug 1102416 desktop-only by adding a pref check to the special getIsUS() function, and only setting that pref for desktop. This is fine because Fennec doesn't need market-specific defaults. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=122ef127a4af

Comment on attachment 8533361 [details] [diff] [review] patch Review of attachment 8533361 [details] [diff] [review]: ----------------------------------------------------------------- r+, but I really think it would be better to go with some code structure that doesn't assume "false" is the safe default for getIsUS(), which is a magic footgun. As one idea, create a wrapper/helper as such: function getGeoSpecificPrefName(basepref) { ... if (!geoSpecificDefaults) return basepref; if (getIsUS()) return basepref + "US."; return basepref; } This also might be useful if we're considering non-US geodefaults in the future.

(In reply to Justin Dolske [:Dolske] from comment #10) > r+, but I really think it would be better to go with some code structure > that doesn't assume "false" is the safe default for getIsUS(), which is a > magic footgun. Yeah I agree. I am going to file a bug on a cleaner solution for this, but I want to avoid making too many changes for 34.*.

Comment on attachment 8533361 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: bug 1102416 [User impact if declined]: comment 0 [Describe test coverage new/current, TBPL]: Fennec coverage lacking [Risks and why]: low risk, since it's effectively a straight backout of bug 1102416, but for Fennec only [String/UUID change made/needed]: none

(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #9) > https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=122ef127a4af Aaron/Flaviu, can you test this build?

Hmm, I think that Android build didn't show up for some reason. Trying again: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5561771683e2

(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #14) > Hmm, I think that Android build didn't show up for some reason. Trying again: > https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5561771683e2 You need to change your trychooser syntax. https://gbrownmozilla.wordpress.com/2014/12/07/new-android-job-names-on-treeherder-update-your-try-pushes/

New push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0dbaf5e11391

Pushing beta to try is broken. Let's try once again: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8f0a1c9ffb1b

(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #17) > Pushing beta to try is broken. Let's try once again: > https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8f0a1c9ffb1b Tested this build yesterday and again today, on new profile we get the correctly listed search default with the aforementioned timezone changes

(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #17) > Pushing beta to try is broken. Let's try once again: > https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8f0a1c9ffb1b Verified on multiple time zones and it works as expected.

(In reply to Flaviu Cos, QA [:flaviu] from comment #19) > (In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #17) > > Pushing beta to try is broken. Let's try once again: > > https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8f0a1c9ffb1b > > Verified on multiple time zones and it works as expected. \o/ let's try to get this landed and uplifted ASAP

Comment on attachment 8533361 [details] [diff] [review] patch given the verifications, let's get this into today's beta - which is not how we usually do things but better to get the extra week of testing with the larger pop.

https://hg.mozilla.org/integration/fx-team/rev/b94f28405aeb https://hg.mozilla.org/releases/mozilla-aurora/rev/7c581a020aa6

Verified as fixed on Firefox 35 Beta 4 on Samsung Galaxy Nexus (Android 4.2.1)

Comment on attachment 8533361 [details] [diff] [review] patch Approved for Firefox for Android 34.0.1.

Verified as fixed on Firefox 34.0.1 and on latest Aurora, on Nexus 5(Android 5.0).

I filed bug 1117186 on fixing this properly for Fennec.

Verified as fixed in Firefox for Android 37.0a1 (2015-01-07) Device: Samsung Galaxy S4 (Android 4.4.2)