Closed Bug 1109636 Opened 10 years ago Closed 10 years ago

[UX] Improve the search panel when suggestions are disabled

Categories

(Firefox :: Search, defect)

36 Branch
x86
macOS
defect
Not set
normal
Points:
5

Tracking

()

RESOLVED FIXED
Iteration:
38.3 - 23 Feb

People

(Reporter: aleth, Assigned: agrigas)

References

Details

(Whiteboard: [ux])

Attachments

(1 file, 2 obsolete files)

This is an edge case that happens when search engine suggestions are turned off, so the 'suggestions' displayed are hits from the user's search history. STR Type a search text that is not in the search history The search text appears * in the search box * as the only suggestion * in the "search for x with" text Expected behaviour: Arguably, three times is a bit much and the "suggestions" top part of the search panel should simply go away when there are no suggestions.
Philipp, I know this was by design, but I also remember you saying "for now". Do you intend to redesign this part of the search panel at some point?
Flags: needinfo?(philipp)
Yes, »for now« is still the current state. The UI is still very much in flux and I'd like to defer changing this to a point when it is more stable.
Flags: needinfo?(philipp)
Summary: Search text appears as a suggestion despite not being in the search history → [UX] Improve the search panel when suggestions are disabled
Flags: qe-verify-
Flags: firefox-backlog+
Whiteboard: [ux]
Assignee: nobody → agrigas
Status: NEW → ASSIGNED
Iteration: --- → 38.3 - 23 Feb
Points: --- → 5
Attached image no suggestions bug.png (obsolete) (deleted) —
Treatment for provider tiles when suggestions are turned off. 2 options pending UI review.
Attachment #8567907 - Flags: ui-review?(shorlander)
Attachment #8567907 - Flags: ui-review?(philippsackl)
There are 2 different cases: - the search suggestions have been disabled by the user - the current default search engine doesn't support offering suggestions I'm not sure if this second case should have a separate UX bug or be handled here, but on the engineering side it likely makes sense to handle the 2 cases at once.
updating the attachment to reflect copy for that use case.
Attached image no suggestions bug.png (obsolete) (deleted) —
please review this not the earlier attachment
Attachment #8567917 - Flags: ui-review?(shorlander)
Attachment #8567917 - Flags: ui-review?(philipp)
Attachment #8567907 - Flags: ui-review?(shorlander)
Attachment #8567907 - Flags: ui-review?(philippsackl)
Attachment #8567907 - Attachment is obsolete: true
Providers should be sorted by frequency of use to make interaction faster
sorry ignore comment above - meant for other bug.
(In reply to Florian Quèze [:florian] [:flo] from comment #4) > There are 2 different cases: > - the search suggestions have been disabled by the user If the user has decided to turn off search suggestions, it's probably not desired to prompt her to turn them on again every time she searches.
Attached image no suggestions v2.png (deleted) —
Updated to remove ability to turn on suggestions inline given they are on by default and it is an explicit action by the user to turn them off.
Attachment #8567917 - Attachment is obsolete: true
Attachment #8567917 - Flags: ui-review?(shorlander)
Attachment #8567917 - Flags: ui-review?(philipp)
Attachment #8568104 - Flags: ui-review?(shorlander)
Attachment #8568104 - Flags: ui-review?(philipp)
Comment on attachment 8568104 [details] no suggestions v2.png I think that works. So the only change to the status quo is to get rid of the lone suggestion that exactly matches the search string, right?
Attachment #8568104 - Flags: ui-review?(philipp) → ui-review+
(In reply to Philipp Sackl [:phlsa] unavailable until Feb. 23 from comment #11) > Comment on attachment 8568104 [details] > no suggestions v2.png > > I think that works. > So the only change to the status quo is to get rid of the lone suggestion > that exactly matches the search string, right? yes that is correct.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8568104 - Flags: ui-review?(shorlander)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: