Closed
Bug 1109740
Opened 10 years ago
Closed 10 years ago
Access MozPaymentProvider on navigator
Categories
(Marketplace Graveyard :: Payments/Refunds, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
2015-01-13
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
(Whiteboard: [qa-])
Attachments
(2 files)
After bug 1097928 MozPaymentProvider will be exposed in the navigator object.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ferjmoreno
Comment 1•10 years ago
|
||
Cool. Sounds super easy. We already use an abstraction like `utils.mozPaymentProvider` so it can be changed in this file: https://github.com/mozilla/spartacus/blob/master/public/js/lib/utils.js#L27
Updated•10 years ago
|
Priority: -- → P1
Summary: [Payments] Access MozPaymentProvider on navigator → Access MozPaymentProvider on navigator
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8544399 -
Flags: review?(kumar.mcmillan)
Comment 3•10 years ago
|
||
Thanks again for the patch!
landed in https://github.com/mozilla/spartacus/pull/181 with a follow up in https://github.com/mozilla/spartacus/commit/7c788164d684747c8b172e2666a04fe3c8fc33a5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → 2015-01-13
Updated•10 years ago
|
Attachment #8544399 -
Flags: review?(kumar.mcmillan) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Thanks Kumar. When is this going to be available in the production server? We need it for FxOS 2.2
Flags: needinfo?(kumar.mcmillan)
Comment 5•10 years ago
|
||
These patches went out to production last week on January 13th. https://github.com/mozilla/spartacus/compare/2015.01.06...2015.01.13 Are you not seeing it? Maybe we missed some part of the code.
Flags: needinfo?(kumar.mcmillan)
Assignee | ||
Comment 6•10 years ago
|
||
I am testing with you in-app payments test app and I am getting this error message:
216 Gec.. I at t (https://marketplace.cdn.mozilla.net/mozpay/media/js/pay-min.js?build=101e07f-54bea79c:5:27738)
216 Gec.. I Content JS LOG: [pay] waiting for paymentFailed to appear in scope
Which seems to come from https://github.com/mozilla/webpay/blob/master/media/js/pay/pay.js that we didn't modify.
Flags: needinfo?(kumar.mcmillan)
Comment 7•10 years ago
|
||
Hmm, that's confusing because theoretically we haven't ran the code that outputs that log message for many deployments now. The payments JS runs from Spartacus: https://github.com/mozilla/spartacus/ . That CDN link doesn't seem right.
Can you attach a logcat with all the GeckoConsole output so I can try to see what code it's running?
paymentSuccess() is called here: https://github.com/mozilla/spartacus/blob/master/public/js/views/payment-success.js and utils.js looks patched correctly: https://github.com/mozilla/spartacus/blob/master/public/js/lib/utils.js#L39
Flags: needinfo?(kumar.mcmillan) → needinfo?(ferjmoreno)
Assignee | ||
Comment 8•10 years ago
|
||
Flags: needinfo?(ferjmoreno) → needinfo?(kumar.mcmillan)
Assignee | ||
Comment 9•10 years ago
|
||
I got the attached logged trying to buy the "Bag of Dice" app from the production Marketplace app on a FxOS build with the latest Gecko and Gaia.
Comment 10•10 years ago
|
||
Thanks for the log!
aha, I see that you were tapping the Cancel button which is incorrectly rendering an old template that serves the wrong JS code. It looks like this bug is limited to only handling the Cancel button redirect. Coincidentally, muffinresearch just discovered this too and will be fixing it in bug 1124676.
The wrong JS is served here: https://github.com/mozilla/webpay/blob/master/webpay/bango/views.py#L128
Depends on: 1124676
Flags: needinfo?(kumar.mcmillan)
Comment 11•10 years ago
|
||
bug 1124676 has been fixed but it won't go to production until Tuesday Feb 3rd. Fernando, if you want me to help you get set up to test on the dev server just let me know - https://marketplace-dev.allizom.org/ Also, I suppose if you do something other than press the Cancel button then you can test it. Are you able to use charge a euro or two to a company SIM?
Flags: needinfo?(ferjmoreno)
Assignee | ||
Comment 12•10 years ago
|
||
Sorry, I missed this needinfo. Payments are working fine now in production. Thanks
Flags: needinfo?(ferjmoreno)
You need to log in
before you can comment on or make changes to this bug.
Description
•