Closed
Bug 1109785
Opened 10 years ago
Closed 6 years ago
Indent all python files to 4 spaces, or at least maintain consistency within a file
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: chmanchester, Assigned: gbrown)
References
Details
Some python test runner files are mixing 2 and 4 space indentation levels, I'm pretty sure we're settled on 4 as the convention.
Comment 1•10 years ago
|
||
rs=me to just forcibly re-indent whole files wherever you want.
Comment 2•10 years ago
|
||
In bug 1127376 I used autopep8 [1] to not only fix whitespace, but other pep8 violations. I'd be down with running all our code through this, two space or not. Though some people will dislike how certain things get styled, at least it enforces a convention.
From bug 1127376 comment 7
> To replicate this patch:
>
> $ pip install --upgrade autopep8
> $ autopep8 -i -a -a -r testing/mochitest --exclude 'testing/mochitest/pywebsocket/*'
[1] https://github.com/hhatto/autopep8
Comment 3•10 years ago
|
||
Consistency is better than the current situation, and PEP8 is generally considered canonical in the Python world, so I'm in agreement for this for all of our testing code.
Assignee | ||
Comment 4•6 years ago
|
||
Enforced by lint now, I believe.
Assignee: nobody → gbrown
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•