Wesley Dawson [:whd] Reporter
	Description • 10 years ago

The "GET STARTED WITH SYNC" button fails in nightly when e10s is enabled, with "TypeError: contentDocument is null (UITour.jsm:535:8)".

	Mike Conley (:mconley) (:⚙️)
	Comment 1 • 10 years ago

Hey Matt - is this a dupe of some pre-existing UITour work to e10s'ify it?

	Matthew N. [:MattN]
	Comment 2 • 10 years ago

Tomasz already did the majority of the work in bug 1073238 so pages like https://www.mozilla.org/en-US/firefox/37.0a1/tour/ mostly work but there are some APIs like this one (showFirefoxAccounts) which needed more work. Also, fixing the tests (bug 1073247) will help discover more of these issues.

	Matthew N. [:MattN]
	Comment 4 • 9 years ago

This can be fixed by using the `browser` variable already defined and using its loadURI method with the URL instead.

Development:
See https://mxr.mozilla.org/mozilla-central/source/browser/components/uitour/UITour.jsm?rev=fd73cdfd2009&mark=330,565-571#328 including the code starting at line 565.
* Docs on <browser>: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/browser 
* loadURI specifically: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/loadURI

Testing instructions:
Test on the URL from the summary in a profile that doesn't have Firefox Sync setup. Clicking "Get started with Sync" should load the sync setup page. Test this with e10s and without to ensure it works with both. (The File menu has options to open both kinds of windows).

	Matthew N. [:MattN]
	Comment 5 • 9 years ago

Note that you can omit the 2nd and 3rd arguments to loadURI

	hharchani Assignee
	Comment 6 • 9 years ago

Is this was expected?

	Matthew N. [:MattN]
	Comment 7 • 9 years ago

Comment on attachment 8555542 [details] [diff] [review]
Bug-1109984-fix.patch

Review of attachment 8555542 [details] [diff] [review]:
-----------------------------------------------------------------

Yes. Thank you very much!

Pushed with cleanup of the contentDocument variable so others don't use it and break e10s.

https://hg.mozilla.org/integration/fx-team/rev/75e4282eb85d

You can find another bug to work on at http://www.joshmatthews.net/bugsahoy/?internals=1&ff=1&unowned=1

::: browser/components/uitour/UITour.jsm
@@ +548,5 @@
>        case "showFirefoxAccounts": {
>          // 'signup' is the only action that makes sense currently, so we don't
>          // accept arbitrary actions just to be safe...
>          // We want to replace the current tab.
> +        browser.loadURI( "about:accounts?action=signup&entrypoint=uitour" );

Nit: For the future we don't put spaces inside function call braces.

	Carsten Book [:Tomcat]
	Comment 8 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/75e4282eb85d