Closed
Bug 1110091
Opened 10 years ago
Closed 10 years ago
mozSettings logging sometimes fails because of missing Services
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox35 wontfix, firefox36 wontfix, firefox37 fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)
RESOLVED
FIXED
2.2 S2 (19dec)
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
qdot
:
review+
bajaj
:
approval-mozilla-b2g34+
|
Details | Diff | Splinter Review |
SettingsRequestManager debugging sometimes fails because of "ReferenceError: Services is not defined".
This makes sense, since we are including Services.jsm after ... I cannot explain why it was working when I tested it.
|
Assignee | |
Updated•10 years ago
|
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → affected
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8534929 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8534930 [details] [diff] [review]
Fix mozSettings logging use of Services r=qdot
Sorry for this mistake :(.
Attachment #8534930 -
Flags: review?(kyle)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8534930 [details] [diff] [review]
Fix mozSettings logging use of Services r=qdot
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1110091
User impact if declined: unable to get more debug from mozSettings
Testing completed: tested on device
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none.
Attachment #8534930 -
Flags: approval-mozilla-b2g34?
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
|
Assignee | |
Comment 6•10 years ago
|
||
The same patch applies cleanly on v2.1.
Try: https://tbpl.mozilla.org/?tree=Try&rev=895ccdb3b5aa
|
||
Updated•10 years ago
|
Attachment #8534930 -
Flags: review?(kyle) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S2 (19dec)
|
||
Updated•10 years ago
|
Attachment #8534930 -
Flags: approval-mozilla-b2g34? → approval-mozilla-b2g34+
|
||
Comment 9•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•