Closed Bug 1110166 Opened 10 years ago Closed 9 years ago

Port |Bug 1102219 - Rename String.prototype.contains to String.prototype.includes| to comm-central

Tracking

(thunderbird39 unaffected, thunderbird40 fixed)

Status:

RESOLVED FIXED

Milestone:

Thunderbird 40.0

Tracking Flags:

Tracking

Status

thunderbird39

---

unaffected

thunderbird40

---

fixed

People

(Reporter: clokep, Assigned: aryx)

References

Details

Attachments

(8 files)

calendar, v1 9 years ago Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) (deleted), patch	Fallen : review+	Details \| Diff \| Splinter Review
chat, v1 9 years ago Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) (deleted), patch	aleth : review+	Details \| Diff \| Splinter Review
editor, v1 9 years ago Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) (deleted), patch	iannbugzilla : review+	Details \| Diff \| Splinter Review
mailnews, v1 9 years ago Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) (deleted), patch	mkmelin : review+	Details \| Diff \| Splinter Review
mail, v1 9 years ago Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) (deleted), patch	mkmelin : review+	Details \| Diff \| Splinter Review
suite/browser, v1 9 years ago Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) (deleted), patch	iannbugzilla : review+	Details \| Diff \| Splinter Review
suite/common, v1 9 years ago Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) (deleted), patch	iannbugzilla : review+	Details \| Diff \| Splinter Review
suite/mailnews, v1 9 years ago Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) (deleted), patch	iannbugzilla : review+	Details \| Diff \| Splinter Review

Patrick Cloke [:clokep]

Reporter

Description

•

10 years ago

Bug 1102219 will bust us, it just landed on mozilla-inbound. I couldn't find a bug about porting this to TB/IB/SM. Figured Archaeopteryx might know what needs to be done for this...

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Assignee

Updated

•

10 years ago

Assignee: nobody → archaeopteryx

Status: NEW → ASSIGNED

Philip Chee

Comment 1

•

10 years ago

(In reply to Patrick Cloke [:clokep] from comment #0) > Bug 1102219 will bust us, it just landed on mozilla-inbound. No it won't. What will really break comm-central is Bug 1103588

Blocks: 1103588
No longer blocks: 1102219

Depends on: 1102219

Patrick Cloke [:clokep]

Reporter

Comment 2

•

10 years ago

(In reply to Philip Chee from comment #1) > (In reply to Patrick Cloke [:clokep] from comment #0) > > Bug 1102219 will bust us, it just landed on mozilla-inbound. > No it won't. What will really break comm-central is Bug 1103588 Yeah, we discussed this on IRC. Not a big deal though, we still need to fix it.

Magnus Melin [:mkmelin]

Comment 3

•

9 years ago

Bug 1102219 jut landed on m-c again, and the tests are pretty much busted since we check for "errors" in the console, and now there is the deprecation warning. "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "String.prototype.contains() is deprecated and will be removed in a future release; use String.prototype.includes() instead" {file: "resource://testing-common/mailnews/imapd.js" line: 1427}]" Error console says [stackFrame String.prototype.contains() is deprecated and will be removed in a future release; use String.prototype.includes() instead] ../../../../mailnews/resources/logHelper.js:_errorConsoleTunnel.observe:95 /opt/comm-central/src/mozilla/testing/xpcshell/head.js:_do_main:207 /opt/comm-central/src/mozilla/testing/xpcshell/head.js:_execute_test:513 -e:null:1 null:null:0 exiting test

Comment hidden (Legacy TBPL/Treeherder Robot)

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=17608 repository: comm-central start_time: 2015-04-30T06:47:43 who: mkmelin+mozilla[at]iki[dot]fi machine: tst-linux32-spot-642 buildname: Ubuntu VM 12.04 comm-central opt test xpcshell revision: f5372ecba286 TEST-UNEXPECTED-FAIL | mail/base/test/unit/test_emptyTrash_dbViewWrapper.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mail/base/test/unit/test_viewWrapper_imapFolder.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mail/base/test/unit/test_viewWrapper_virtualFolderCustomTerm.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_offlineDraftDataloss.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_offlineDraftDataloss.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_bug695309.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_bug695309.js | test_newMsgs - [test_newMsgs : 48] 0 == 3 TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_bug695309.js | _async_driver - TypeError: ex.stack is undefined at ../../../resources/asyncTestUtils.js:169 TEST-UNEXPECTED-FAIL | mail/base/test/unit/test_viewWrapper_logic.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/base/test/unit/test_detachToFile.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/base/test/unit/test_imapPump.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/base/test/unit/test_junkingWhenDisabled.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/base/test/unit/test_mimemaltdetach.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/base/test/unit/test_nsMsgDBView_headerValues.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/base/test/unit/test_nsMsgDBView.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/base/test/unit/test_testsuite_fakeserver_imapd_gmail.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/base/test/unit/test_testsuite_fakeserver_imapd_list-extended.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/compose/test/unit/test_sendMessageLater2.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_cleanup_msf_databases.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_fts3_tokenizer.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_gloda_content_imap_offline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_index_addressbook.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_gloda_content_local.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_index_bad_messages.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_index_junk_imap_offline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_index_compaction.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_index_junk_imap_online.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_index_junk_local.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_index_messages_imap_offline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_index_messages_imap_online.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_index_messages_imap_online_to_offline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_index_messages_local.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_intl.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_migration.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_msg_search.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_query_messages_imap_offline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_query_messages_imap_online.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_smime_mimemsg_representation.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_query_messages_imap_online_to_offline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_startup_offline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/db/gloda/test/unit/test_query_messages_local.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_autosync_date_constraints.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_bccProperty.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_bug460636.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_chunkLastLF.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_customCommandReturnsFetchResponse.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_copyThenMove.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_dod.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_downloadOffline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_fetchCustomAttribute.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_filterCustomHeaders.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_filterNeedsBody.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_gmailAttributes.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_gmailOfflineMsgStore.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapAutoSync.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapContentLength.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapFlagChange.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapHdrStreaming.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapMove.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapSearch.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapStoreMsgOffline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapUndo.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_largeOfflineStore.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_localToImapFilterQuarantine.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_offlineCopy.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_partsOnDemand.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_preserveDataOnMove.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_saveImapDraft.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_saveTemplate.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_stopMovingToLocalFolder.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_subfolderLocation.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_syncChanges.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_trustSpamAssassin.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_autosync_date_constraints.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_bccProperty.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_bug460636.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_customCommandReturnsFetchResponse.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_copyThenMove.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_downloadOffline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_fetchCustomAttribute.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_filterCustomHeaders.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_filterNeedsBody.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_gmailAttributes.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_gmailOfflineMsgStore.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapAutoSync.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapFlagChange.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapHdrStreaming.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapMove.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapSearch.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapStoreMsgOffline.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapUndo.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_localToImapFilterQuarantine.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_offlineCopy.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_partsOnDemand.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_preserveDataOnMove.js | xpcshell return code: -11 PROCESS-CRASH | mailnews/imap/test/unit/test_preserveDataOnMove.js | application crashed [@ nsContentUtils::GetSafeJSContext()] TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_saveImapDraft.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_saveTemplate.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_stopMovingToLocalFolder.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_subfolderLocation.js | xpcshell return code: 0

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Assignee

•

9 years ago

Attached patch suite/common, v1 (deleted) — Details — Splinter Review

Attachment #8600284 - Flags: review?(neil)

aleth [:aleth]

Comment 13

•

9 years ago

Comment on attachment 8600279 [details] [diff] [review] chat, v1 Review of attachment 8600279 [details] [diff] [review]: ----------------------------------------------------------------- ::: chat/protocols/irc/ircCommands.jsm @@ +284,5 @@ > name: "mode", > get helpString() _("command.modeUser", "mode") + "\n" + > _("command.modeChannel", "mode"), > run: function(aMsg, aConv) { > + function isMode(aString) "+-".includes(aString[0]); Can I ask you to change this to let isMode = aString => "+-".includes(aString[0]); while you are at it, or we'll just get a different warning? Looks like this line was overlooked in the recent removal of this kind of deprecated short function definiton.

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Assignee

Comment 14

•

9 years ago

Attached patch suite/mailnews, v1 (deleted) — Details — Splinter Review

Attachment #8600286 - Flags: review?(neil)

aleth [:aleth]

Comment 15

•

9 years ago

Attachment #8600279 - Flags: review?(aleth) → review+

Philipp Kewisch [:Fallen] [:📆][:🧩]

Updated

•

9 years ago

Attachment #8600278 - Flags: review?(philipp) → review+

Ian Neal

Comment 16

•

9 years ago

(In reply to Archaeopteryx [:aryx] from comment #11) > Created attachment 8600283 [details] [diff] [review] > suite/browser, v1 Isn't there some in suite/browser/navigator.js?

Flags: needinfo?(archaeopteryx)

Ian Neal

Comment 17

•

9 years ago

(In reply to Archaeopteryx [:aryx] from comment #12) > Created attachment 8600284 [details] [diff] [review] > suite/common, v1 Isn't there some in: suite/common/downloads/downloadmanager.js suite/common/search/search.xml suite/common/sidebar/sidebarOverlay.js

Ian Neal

Updated

•

9 years ago

Attachment #8600280 - Flags: review?(iann_bugzilla) → review+

Ian Neal

Comment 18

•

9 years ago

Comment on attachment 8600286 [details] [diff] [review] suite/mailnews, v1 Stealing, r=me

Attachment #8600286 - Flags: review?(neil) → review+

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Assignee

Comment 19

•

9 years ago

(In reply to Ian Neal from comment #16) > (In reply to Archaeopteryx [:aryx] from comment #11) > > Created attachment 8600283 [details] [diff] [review] > > suite/browser, v1 > > Isn't there some in suite/browser/navigator.js? None of them are strings: > line 694 -- if (!next || !next.classList.contains("nav-bar-class")) > line 697 -- if (!previous || !previous.classList.contains("nav-bar-class")) classLists > line 2132 -- if (!title || frameset.document.styleSheetSets.contains(title)) { DOMStringList (In reply to Ian Neal from comment #17) > (In reply to Archaeopteryx [:aryx] from comment #12) > > Created attachment 8600284 [details] [diff] [review] > > suite/common, v1 > > Isn't there some in: > suite/common/downloads/downloadmanager.js > line 680 -- if (types.contains("text/uri-list") || > line 681 -- types.contains("text/x-moz-url") || > line 682 -- types.contains("text/plain")) DOMStringList > suite/common/search/search.xml DOMStringList and classLists > suite/common/sidebar/sidebarOverlay.js classLists

Flags: needinfo?(archaeopteryx)

Magnus Melin [:mkmelin]

status-thunderbird39: --- → unaffected

status-thunderbird40: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Thunderbird 40.0

You need to log in before you can comment on or make changes to this bug.