Closed
Bug 1110235
Opened 10 years ago
Closed 10 years ago
Clicking on the header region of the search dropdown should trigger a search with the default engine
Categories
(Firefox :: Search, defect)
Tracking
()
People
(Reporter: phlsa, Assigned: Felipe)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
florian
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We observed some people trying to click that region (the header saying »Yahoo Search«) to initiate a search. We should make that possible.
Also, Cmd-Click should open the search in a new tab, to be consistent.
We don't need any visual feedback here for the moment.
Comment 1•10 years ago
|
||
Would you be interested in taking this bug too? I'm asking mostly because I'm thinking you may want to register this differently on telemetry.
Flags: needinfo?(bwinton)
Comment 2•10 years ago
|
||
I could take a stab at it, while I wait for reviews…
(I make no promises about whether or not I'll get it done this iteration, though! ;)
Assignee: nobody → bwinton
Status: NEW → ASSIGNED
Iteration: --- → 37.2
Points: --- → 2
Flags: needinfo?(bwinton) → qe-verify+
Assignee | ||
Comment 3•10 years ago
|
||
I'm gonna steal this one while Blake works on bug 1106432
Assignee: bwinton → felipc
Comment 4•10 years ago
|
||
Thanks Felipe! :D
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8538492 -
Flags: review?(florian)
Comment 6•10 years ago
|
||
Comment on attachment 8538492 [details] [diff] [review]
Patch
Review of attachment 8538492 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/urlbarBindings.xml
@@ +1202,5 @@
> let button = event.originalTarget;
> + if (!button.engine)
> + button = button.parentNode;
> +
> + if (!button.engine)
Would this be cleaner?
let engine = button.engine || button.parentNode.engine;
if (!engine)
return;
Attachment #8538492 -
Flags: review?(florian) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•10 years ago
|
Flags: firefox-backlog+
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8538492 [details] [diff] [review]
Patch
Approval Request Comment
[Feature/regressing bug #]: new search UI
[User impact if declined]: User research has shown that some users tried to click the panel header (which says "Yahoo Search") and expected it to be a clickable trigger to search.
[Describe test coverage new/current, TBPL]: tests for the new search UI are still to-do
[Risks and why]: very small risk, simple change
[String/UUID change made/needed]: none
Attachment #8538492 -
Flags: approval-mozilla-aurora?
Comment 10•10 years ago
|
||
Comment on attachment 8538492 [details] [diff] [review]
Patch
Approval Request Comment
I think we should take this for 35 too, as it's very low risk, and can avoid user confusion (and missed searches).
Attachment #8538492 -
Flags: approval-mozilla-beta?
Updated•10 years ago
|
status-firefox37:
--- → fixed
Updated•10 years ago
|
Attachment #8538492 -
Flags: approval-mozilla-beta?
Attachment #8538492 -
Flags: approval-mozilla-beta+
Attachment #8538492 -
Flags: approval-mozilla-aurora?
Attachment #8538492 -
Flags: approval-mozilla-aurora+
Comment 11•10 years ago
|
||
Comment 12•10 years ago
|
||
Verified fixed on Firefox 35.0b6 (20141222200458) using Ubuntu 12.04 LTS 32-bit, Windows 8.1 64-bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Comment 13•10 years ago
|
||
Verified as fixed using Developer Edition 36.0a2 and Nightly 37.0a1 2014-01-05 under Ubuntu 12.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5.
You need to log in
before you can comment on or make changes to this bug.
Description
•