Closed
Bug 1110457
Opened 10 years ago
Closed 10 years ago
Switch prefs API to standard Proxy API
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: irakli, Assigned: irakli)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8535204 -
Flags: review?(evold)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → rFobic
|
||
Updated•10 years ago
|
Attachment #8535204 -
Flags: review?(evold) → review+
|
|
||
Updated•10 years ago
|
Blocks: sdk/simple-prefs
|
||
Comment 2•10 years ago
|
||
So now that I fixed bug 783829, you presumably do this. Some comments:
enumerate must return an iterator, like function*() { for (let x of keys()) yield x; }
getEnumerablePropertyKeys does not exist.
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
|
||
Comment 4•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/b2f6f38dd6d6f939c64a3a3677c18f45c9f73836
Merge pull request #1746 from Gozala/simple-pref-new-proxy
Bug 1110457 - Update prefs implementation to use newer proxy API. r=@erikvold
|
|
Assignee | |
Comment 5•10 years ago
|
||
This is not duplicate.
|
|
Assignee | |
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
|
|
Assignee | |
Comment 6•10 years ago
|
||
Fixed by the commit above.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•