Closed
Bug 1110701
Opened 10 years ago
Closed 10 years ago
End/Leave button takes some seconds to work after joining a Room
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: oteo, Assigned: jaoo)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
After joining a Room, although the end button is shown and it's ready to be tapped, there is no action when clicking on it. You have to wait for some seconds to be able to leave the room.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → josea.olivera
Assignee | ||
Comment 1•10 years ago
|
||
I did some reordering in the flow we follow when the user leaves the room, could you let us know if it works better now please? Thanks!
P.S. Code lives at https://github.com/jaoo/firefoxos-loop-client/tree/1110701
Attachment #8535624 -
Flags: feedback?(oteo)
Reporter | ||
Comment 2•10 years ago
|
||
Unfortunately I can not see improvement :(
Reporter | ||
Updated•10 years ago
|
Attachment #8535624 -
Flags: feedback?(oteo)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8535624 [details]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/399
Second try, would you mind to check whether it works better now? Thanks!
Attachment #8535624 -
Flags: feedback?(oteo)
Reporter | ||
Comment 4•10 years ago
|
||
Thanks a lot Jo se Antonio! It works quite well but only the first time after installing your branch. After the installation, I enter in a room and I can leave it intermediately without any issue :)
For the second and subsequent times I am reproducing the bug reported, you are almost there!
Reporter | ||
Updated•10 years ago
|
Attachment #8535624 -
Flags: feedback?(oteo)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8535624 [details]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/399
New and hope last version of the patch. I tried to speed up as much as possible the end of the chat in the room. Right after the user finishes the chat, the remote video is deleted and the feedback screen is shown. Maria, could you give it a try? Thanks. Borja, the patch is ready for the review. If you see how to speed up (even more) the end of the chat, please let's know! Thanks!
Attachment #8535624 -
Flags: review?(borja.bugzilla)
Attachment #8535624 -
Flags: feedback?(oteo)
Reporter | ||
Updated•10 years ago
|
Attachment #8535624 -
Flags: feedback?(oteo)
Reporter | ||
Comment 6•10 years ago
|
||
Now, it's working fine, so closing the bug as Worksforme.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Updated•10 years ago
|
Attachment #8535624 -
Flags: review?(borja.bugzilla)
You need to log in
before you can comment on or make changes to this bug.
Description
•