This got missed in bug 1107255.

Comment on attachment 8535840 [details] [diff] [review] loop panel should close on 'Start a Conversation' click Approval Request Comment [Feature/regressing bug #]: Rooms [User impact if declined]: annoyance that the panel closes if you click on a conversation (recently fixed) but doesn't close if you create a conversation (i.e. the previous fix missed this case). [Describe test coverage new/current, TBPL]: on m-c momentarily. Includes tests. [Risks and why]: low risk; extends existing functionality to one more case; includes test. Simple patch. [String/UUID change made/needed]: none

This is going to conflict with room creation failing - which I've got in another bug somewhere. If the create fails, then the panel will be closed and we can't inform the user. I'm not quite sure what we can do here. Leaving the panel open until we've got confirmation might be best but possibly hard to write.

I know UX prefers for the panel to close, and the Hello UI Tour folks are counting on it closing for their work. I was expecting that if room creation failed, we'd show "something went wrong" in the conversation view window (that just popped up, where the room conversation would have happened), not the panel. Is it a problem to do it that way?

+ Holly, and adding as a blocker for the GA 35 Hello tour. Our designs depend on this working as expected.

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #6) > I was expecting that if room creation failed, we'd show "something went > wrong" in the conversation view window (that just popped up, where the room > conversation would have happened), not the panel. Is it a problem to do it > that way? Yes, that would be very difficult - we don't open the room until we have the information necessary, as we need the room token information etc. IMO, its also strange UX for start conversation to fail, but then the failure message to be displayed in a separate part. I think the most sensible thing to do would be to close the panel once we have acknowledgement of success from the server, but I don't know what that looks like from a code perspective at the moment.

I think it makes sense to move this discussion to bug 1109149. However, I just want to say that I think having the conversation view open, show your self view (until we get room info) and then display "something went wrong" in that new conversation window if room creation failed would make sense. I think it would be a lot less cluttered/confusing than trying to display it in the panel (which could have several rooms listed already), but we should ask Sevaan. I also appreciate wanting to do something not too complicated/complex. I'll repeat these comments in bug 1009149.

>I'll repeat these comments in bug 1009149. Err, I mean bug 1109149.

See also bug 1111700, which I just filed.