Closed Bug 1111743 Opened 10 years ago Closed 9 years ago

Annotate Shumway functions to be inlined

Categories

(Firefox Graveyard :: Shumway, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: cpeterson, Assigned: tschneider)

References

Details

(Keywords: perf)

From Shumway meeting on 2014-12-09: https://etherpad.mozilla.org/shumwaymeeting Is this for Shumway's own TS code and/or the Shumway JIT's generated JS code?
This is for Shumway's own code: the idea is to add annotations to the source and to modify our version of the Closure Compiler to make it inline the annotated functions.
Blocks: shumway-jw2
No longer blocks: shumway-fb2
Support for doing this landed in https://github.com/mozilla/shumway/pull/2127. Do we want to keep this ticket open as some sort of meta ticket to track the actual work of annotating all the functions we want to have being inlined?
Flags: needinfo?(till)
Flags: needinfo?(cpeterson)
Now that you've landed Closure support for inline functions, I think it makes sense to keep this bug open for a first pass annotating some obvious hotspots. After that, I don't think there would be much value to keep this bug open as a meta bug for all future inline function annotations. I assume future annotations would be the result of guided profiling of specific performance problems or as a part of normal feature development.
Blocks: shumway-m5
Flags: needinfo?(cpeterson)
I concur.
Flags: needinfo?(till)
No longer blocks: shumway-jw2
Blocks: shumway-jw2
Blocks: shumway-1.0
No longer blocks: shumway-m5
Product: Firefox → Firefox Graveyard
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.