- Step Open the following data URL data:text/html,<div style="writing-mode: vertical-rl;"><ol><li>ABC</li></ol></div> - Result number of ordered list doesn't use vertical layout - Expected Result number of ordered list shoulder use vertical layout

Currently list item markers are drawn by nsLayoutUtils::DrawString, not gfxTextRun. We probably need to make DrawString vertical-capable (we will also want that at some point for page headers and footers), but see also bug 397294.

Yes, I was thinking about this recently too. The effect is more fun if you have item markers with varying lengths... :) data:text/html,<div style="writing-mode: vertical-rl;"><ol style="list-style-type:lower-roman"><li>ABC</li><li>ABC</li><li>ABC</li><li>ABC</li><li>ABC</li><li>ABC</li><li>ABC</li><li>ABC</li><li>ABC</li><li>ABC</li></ol></div>

(In reply to Simon Montagu :smontagu from comment #1) > Currently list item markers are drawn by nsLayoutUtils::DrawString, not > gfxTextRun. We probably need to make DrawString vertical-capable (we will > also want that at some point for page headers and footers), but see also bug > 397294. Using gfxTextRun directly can't work, because the marker may involve multiple bidi runs; so we still need to go through something like nsBidiPresUtils::ProcessText to resolve bidi and generate multiple runs if necessary. I think making nsLayoutUtils::DrawString handle vertical text is probably the right way forward here.

This seems to work so far, though I won't be surprised if something more is needed as we test this from the various call-sites.

Hmm, tryserver says the reftest fails on most platforms. :( Looks like this may be primarily due to bad line-spacing metrics of the fallback CJK font that's getting used. Need to look into that anyway for some other bugs, too...

Updated reftest slightly for better robustness. With the font metrics patches from bug 1090329, bug 1095334 and bug 1115916, this passes as expected. https://treeherder.mozilla.org/#/jobs?repo=try&revision=15dd7ce9867b

https://hg.mozilla.org/integration/mozilla-inbound/rev/646e58995d53 https://hg.mozilla.org/integration/mozilla-inbound/rev/603b4a6ccd6a https://hg.mozilla.org/integration/mozilla-inbound/rev/d3bbe13bbd08

https://hg.mozilla.org/mozilla-central/rev/646e58995d53 https://hg.mozilla.org/mozilla-central/rev/603b4a6ccd6a https://hg.mozilla.org/mozilla-central/rev/d3bbe13bbd08