Closed
Bug 1112071
Opened 10 years ago
Closed 9 years ago
consider using QuotaManager origin/group when determining Manager uniqueness in Service Worker Cache
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Currently the Service Worker Cache determines Manager object uniqueness based on these values:
- origin
- appId
- browser element flag
The QuotaManager, however, has some logic to possibly combine different origins into the same directory. For example, I think some about: pages end up with the same quota directory.
If this directory combining happens, then we will have two different Manager's accessing the same files on disk. This breaks a number of invariants in the design.
We should verify if this is a problem and include the result of QuotaManager::GetInfoFromPrincipal() in the Manager uniqueness test.
Comment 1•10 years ago
|
||
That about: stuff is primarily for the loop component (firefox hello). I was not very happy when it was added. I want to remove it, maybe as part of qm v2. We found out that loop guys actually don't use this combining of different origins into the same directory.
I believe you don't have to worry about this at all.
Assignee | ||
Comment 2•10 years ago
|
||
Close per Jan's comment 1.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Assignee | ||
Comment 3•9 years ago
|
||
Turns out we do need this since QuotaManager modifies the origin in other ways. For example, it uses "chrome" instead "[system principal]". This is blocking my xpcshell scripts in bug 1184607.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bkelly
Status: REOPENED → ASSIGNED
Assignee | ||
Comment 4•9 years ago
|
||
This is necessary for Cache to behave properly for the system principal. In particular, I need this for the xpcshell tests I'm writing over in bug 1184607.
Attachment #8654201 -
Flags: review?(ehsan)
Assignee | ||
Comment 5•9 years ago
|
||
Accidentally included some other changes in the first patch.
Attachment #8654201 -
Attachment is obsolete: true
Attachment #8654201 -
Flags: review?(ehsan)
Attachment #8654209 -
Flags: review?(ehsan)
Updated•9 years ago
|
Attachment #8654209 -
Flags: review?(ehsan) → review+
Comment 8•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•