Closed
Bug 1112112
Opened 10 years ago
Closed 10 years ago
Add logging for e10s parent-child channels
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla37
| Tracking | Status | |
|---|---|---|
| e10s | + | --- |
People
(Reporter: dragana, Assigned: dragana)
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
dragana
:
review+
|
Details | Diff | Splinter Review |
Additional logging for e10s channels
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → dd.mozilla
tracking-e10s:
--- → +
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8537955 -
Flags: review?(jduell.mcbugs)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8537955 -
Attachment is obsolete: true
Attachment #8537955 -
Flags: review?(jduell.mcbugs)
Attachment #8537960 -
Flags: review?(jduell.mcbugs)
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8537960 [details] [diff] [review]
add logging v1
Review of attachment 8537960 [details] [diff] [review]:
-----------------------------------------------------------------
::: netwerk/protocol/http/HttpChannelChild.cpp
@@ +216,5 @@
> {}
>
> void Run()
> {
> + LOG(("StartRequestEvent [this=%x]\n", mChild));
mChild is a pointer, so we need %x (IIRC %x is only 32 bits on some platforms that have 64 bit pointers: I'm pretty sure we had a bug where we converted %x -> %p everywhere for that reason).
@@ +643,5 @@
> void
> HttpChannelChild::DoPreOnStopRequest(nsresult aStatus)
> {
> + LOG(("HttpChannelChild::DoPreOnStopRequest [this=%p status=%d]\n",
> + this, aStatus));
nsresults are uint32_t. This patch has a mix of %x, %u, and %d for them. %d would appear incorrect (though I don't know if it matters, ie if we have values that would be converted to negative ints). Might as well switch to whichever of %x/%u is more predominant in the code.
Attachment #8537960 -
Flags: review?(jduell.mcbugs) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8537960 -
Attachment is obsolete: true
Attachment #8545816 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•10 years ago
|
||
rebased
Attachment #8545816 -
Attachment is obsolete: true
Attachment #8545924 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•