Ben Kelly [:bkelly, not reviewing] Reporter
	Description • 10 years ago

One of the outcomes of the various principal work was that ServiceWorkers should not be usable from a private browsing session.  To allow feature detection to work we should hide the SW API when in private browsing mode.

	Ben Kelly [:bkelly, not reviewing] Reporter
	Comment 1 • 10 years ago

What do you think we should do with the other SW APIs in private browsing mode?  In bug 1112134 you felt hiding was the wrong solution.

The SW registration is persistent of course, so that's why it matters here.

Perhaps its easier just not to persist the registration in this case?

	(no longer active) Assignee
	Comment 2 • 10 years ago

Non-persistent registrations are not very useful though.

Can we just make ServiceWorkerContainer.register() return a Promise which will never get resolved?  The same scenario would happen if, for example, the user doesn't grant permission when we prompt them during the register() call, so those cases would be indistinguishable from the viewpoint of the Web author.

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 3 • 10 years ago

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #2)
> Non-persistent registrations are not very useful though.
> 
> Can we just make ServiceWorkerContainer.register() return a Promise which
> will never get resolved?  The same scenario would happen if, for example,
> the user doesn't grant permission when we prompt them during the register()
> call, so those cases would be indistinguishable from the viewpoint of the
> Web author.

The spec never mentions prompting the user, but leaving a Promise unresolved seems an ugly approach. Rejecting the promise with SecurityError or PermissionDeniedError may be better.

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 4 • 10 years ago

PermissionDeniedError - https://www.w3.org/Bugs/Public/show_bug.cgi?id=23033

	(no longer active) Assignee
	Comment 5 • 10 years ago

You're right, rejection is definitely better.

	Noemí Freire (:noemi)
	Comment 6 • 9 years ago

I guess it should block v2. Please, change it if it is not the case. Thanks!

	Ben Kelly [:bkelly, not reviewing] Reporter
	Comment 7 • 8 years ago

We fixed this at some point in another bug.