Closed
Bug 1112435
Opened 10 years ago
Closed 8 years ago
Breakpoint in pretty printed source not hit on reload
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: nazar, Unassigned)
References
(Blocks 3 open bugs)
Details
If "Automatically Black Box Minified Sources" is used - whenever you un-Black Box some file - breakpoints will not work in it anyway. Any kind of breakpoints - added manually, conditional, "debugger" in source code.
Comment 1•10 years ago
|
||
Are you saying debugger statements don't work either? That's interesting, because those use a very different mechanism internally than breakpoints.
Blocks: dbg-breakpoint
Flags: needinfo?(nazar)
Summary: Automatic Black Boxing of minified sourced breaks breakpoints → Debugger no longer pauses on automatically blackboxed sources after unblackboxing them
Reporter | ||
Comment 2•10 years ago
|
||
Exactly. Moreover, sometimes only debugger statements work, not breakpoints, but I do not know how to reproduce this, and this is another situation (I'm not blackboxing anything anymore).
Flags: needinfo?(nazar)
Comment 3•9 years ago
|
||
I just had this problem while trying to debug event issues in bug 1138335.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•9 years ago
|
||
Any test case w/ steps to reproduce for this? That would go a long way towards helping get this fixed.
Flags: needinfo?(nazar)
Flags: needinfo?(hsteen)
Comment 5•9 years ago
|
||
1. load jquery.com
2. unblackbox jquery.min.js and reformat
3. set breakpoint on "return new m.fn.init(a, b)" line (line 23 in our reformatted source)
4. reload
Script is not shown greyed out (seems un-blackboxed), breakpoints are listed and shown as enabled - but it doesn't actually *stop* on them :-/
Flags: needinfo?(hsteen)
Comment 7•9 years ago
|
||
Thanks. I can repro now, but I'm not sure if this is an issue with the prettifier and/or source maps and breakpoints or black boxing.
Blocks: dbg-sourcemap, dbg-blackbox
Flags: needinfo?(nfitzgerald)
Comment 8•9 years ago
|
||
Interesting.
If I use a different source, black box that source, un black box that source, and then try to hit a breakpoint, then it succeeds.
If I turn off auto-black-boxing, and do the STR from comment 5 (sans un black boxing, obviously), then the breakpoint also succeeds.
Flags: needinfo?(nazar)
Comment 9•9 years ago
|
||
Ah, no wait. I can always make the breakpoint hit via `$("a")` in the console. This is an issue with breakpoints and pretty printed sources on reload. Most likely a race condition between the pretty printing finishing in a worker and the refresh + breakpoint being hit or something.
Summary: Debugger no longer pauses on automatically blackboxed sources after unblackboxing them → Breakpoint in pretty printed source not hit on reload
Updated•9 years ago
|
Comment 10•8 years ago
|
||
I'm closing this bug as it does not pertain to the new UI.
The new UI does pretty printing on the client, which allows the server to only keep generated locations.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Comment 11•7 years ago
|
||
Using formatted code for breakpoints is still fully broken for me. FF 53.0.3 Win7 32bit. Always. Reproducible.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•